Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor additional flag when processing OnChangeViewReceived #641

Merged
merged 2 commits into from
Mar 18, 2019
Merged

Minor additional flag when processing OnChangeViewReceived #641

merged 2 commits into from
Mar 18, 2019

Conversation

vncoelho
Copy link
Member

Talking to @fabwa, @belane and @shargon it was detected a need to include this additional flag that was missed during the journey.

@vncoelho
Copy link
Member Author

vncoelho commented Mar 18, 2019 •
edited
Loading

Thanks, @shargon, miss-clicked the copy and paste.

@shargon shargon requested review from jsolman and erikzhang March 18, 2019 17:26
@vncoelho vncoelho changed the title Minor aditional flag when processing OnChangeViewReceived Minor additional flag when processing OnChangeViewReceived Mar 18, 2019
@jsolman
Copy link
Contributor

jsolman commented Mar 18, 2019 •
edited
Loading

This is an important check that was present at the point of #579 but was lost along the way during additional changes in #547. Specifically this Commit lost the return when the Commit flag was set:
19ada04

@vncoelho vncoelho merged commit b6ad2cc into master Mar 18, 2019
@vncoelho vncoelho deleted the commit-sent-flag-return-onchangeview branch March 18, 2019 19:34
@jsolman jsolman mentioned this pull request Mar 19, 2019
Merged
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
@superboyiii @Celia18305
Additions for plugin introduction. (neo-project#641)
d33c8b9 
Additions for plugin introduction.
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
@Celia18305 @PeterLinX
sync up with neo-project#641 (neo-project#646)
6ed1396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsolman jsolman jsolman approved these changes

@erikzhang erikzhang Awaiting requested review from erikzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vncoelho @jsolman @shargon