Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for ActorSystem termination before returning from Dispose() of NeoSystem. #607

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

jsolman
Copy link
Contributor

@jsolman jsolman commented Feb 25, 2019

Fixes #603
When using a pattern such as the following:

using (var store = new LevelDBStore(path))
using (var system = new NeoSystem(store)) {
    ...
}

The store needs to wait to be disposed until after the ActorSystem termination. This implements that.

Also, neo-cli was plagued by the same issue since it did the following on shutdown:

system.Dispose();
store.Dispose();

Fixes #607

@erikzhang erikzhang merged commit b5bd56d into master Feb 26, 2019
@erikzhang erikzhang deleted the WaitForTerminated branch February 26, 2019 02:21
rodoufu pushed a commit to rodoufu/neo that referenced this pull request Mar 5, 2019
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
* 添加文档“搭建私有链的简易方法”

* Update private-chain2.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants