Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Remove OpCode.HASH160 and OpCode.HASH256 #146

Merged
merged 4 commits into from
May 8, 2019
Merged

Conversation

erikzhang
Copy link
Member

Since OpCode.HASH160 and OpCode.HASH256 are combinations of different hash operations, we can provide some more basic hash algorithms and then remove the two combined instructions.

@codecov-io
Copy link

codecov-io commented May 8, 2019

Codecov Report

Merging #146 into master will decrease coverage by 6.94%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
- Coverage   79.82%   72.87%   -6.95%     
==========================================
  Files          43       40       -3     
  Lines        4450     3355    -1095     
==========================================
- Hits         3552     2445    -1107     
- Misses        898      910      +12
Impacted Files Coverage Δ
tests/neo-vm.Tests/Types/Crypto.cs 2.94% <ø> (-4.34%) ⬇️
...ts/neo-vm.Tests/Types/VMUTExecutionContextState.cs 100% <ø> (ø) ⬆️
src/neo-vm/Unsafe.cs 54.71% <ø> (-45.29%) ⬇️
tests/neo-vm.Tests/Cryptography/ECC/ECCurve.cs 0% <ø> (ø) ⬆️
tests/neo-vm.Tests/VMJsonTestBase.cs 100% <ø> (ø) ⬆️
tests/neo-vm.Tests/Types/InteropService.cs 100% <ø> (ø) ⬆️
tests/neo-vm.Tests/UtDebugger.cs 100% <100%> (ø) ⬆️
src/neo-vm/ExecutionEngine.cs 99.54% <100%> (-0.01%) ⬇️
src/neo-vm/Script.cs 93.75% <100%> (+4.86%) ⬆️
src/neo-vm/Debugger.cs 100% <100%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a5b2f...846bf0a. Read the comment docs.

@erikzhang
Copy link
Member Author

We can discuss whether to remove opcodes such as CHECKSIG in a separate issue. If removed, it means that users need to change their addresses when migrating from 2.x to 3.0.

@shargon
Copy link
Member

shargon commented May 8, 2019

In fact, we should warn the users to use regular wallets before the migration. @igormcoelho @vncoelho i remember that you have a repository for allow users to create complex wallets for charity

shargon
shargon previously approved these changes May 8, 2019
@shargon
Copy link
Member

shargon commented May 8, 2019

Even if we eliminate TAILCALL, I prefer to have CallingScript inside ExecutionContext, is more clear.

@erikzhang
Copy link
Member Author

Even if we eliminate TAILCALL, I prefer to have CallingScript inside ExecutionContext, is more clear.

Done.

@erikzhang erikzhang merged commit b7f7dc9 into master May 8, 2019
@erikzhang erikzhang deleted the 3.0/remove-hash branch May 8, 2019 08:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants