Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Clean ICrypto files #147

Merged
merged 1 commit into from
May 8, 2019
Merged

Conversation

shargon
Copy link
Member

@shargon shargon commented May 8, 2019

Maybe we should remove ICrypto, and move VERIFY and CHECKSIGN to a syscall

@shargon shargon requested a review from erikzhang May 8, 2019 07:13
@codecov-io
Copy link

codecov-io commented May 8, 2019

Codecov Report

Merging #147 into 3.0/remove-hash will increase coverage by 17.06%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           3.0/remove-hash    #147       +/-   ##
===================================================
+ Coverage            55.84%   72.9%   +17.06%     
===================================================
  Files                   42      40        -2     
  Lines                 4380    3355     -1025     
===================================================
  Hits                  2446    2446               
+ Misses                1934     909     -1025
Impacted Files Coverage Δ
tests/neo-vm.Tests/Cryptography/ECC/ECCurve.cs 0% <ø> (ø) ⬆️
tests/neo-vm.Tests/Types/Crypto.cs 2.94% <ø> (+1.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a441704...f1fc1ac. Read the comment docs.

@erikzhang erikzhang merged commit 9fb4ac1 into neo-project:3.0/remove-hash May 8, 2019
@shargon shargon deleted the remove-icrypto branch May 8, 2019 07:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants