schema 300 leftovers #431
Merged
schema 300 leftovers #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere there are no foreign keys
…di-modelchecker into margriet_schema_300_leftovers
* Collect all present ForeignKeyChecks and modify generate_foreign_key_checks to generate these checks * Move all foreign key checks in QueryChecks to actual ForeignKeyChecks * Add unique check for boundary_condition_1d.connection_node_id
Checks for * Formatting of dry_weather_flow.distribution string * Number of values in dry_weather_flow.distribution (should be 24) * Sum of values in dry_weather_flow.distribution (should be 100)
* Check if geometries for orifice, weir and pipe match their connection nodes * Extend LinestringLocationCheck for all checks for linestring geometries that should match objects * Replace CrossSectionLocationCheck with generic PointLocationCheck
…di-modelchecker into margriet_schema_300_leftovers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch used to collect the leftover tasks. PRs for these tasks were merged into this branch, so review of this branch is not necessary.