Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up generic checks #419

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Clean up generic checks #419

merged 7 commits into from
Dec 10, 2024

Conversation

margrietpalm
Copy link
Contributor

  • Collected all foreign key checks and modified generate_foreign_key_checks to handle them
  • Added unique check for boundary_condition_1d.connection_node_id and modified 'generate_unique_checks' to handle extra fields
  • No changes for the not null checks needed

@margrietpalm margrietpalm requested a review from elisalle December 6, 2024 15:32
@margrietpalm margrietpalm merged commit 11d623a into margriet_schema_300_leftovers Dec 10, 2024
7 checks passed
@margrietpalm margrietpalm deleted the margriet_406_clean_up_generic_checks branch December 10, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elisalle elisalle elisalle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@margrietpalm @elisalle