-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus grafana & add cirun.io #733
Conversation
...template/{{ cookiecutter.repo_directory }}/infrastructure/modules/kubernetes/ingress/main.tf
Outdated
Show resolved
Hide resolved
I'd prefer if we could pull in the helm charts to minimize the number of files in qhub (also making updates easier) similar to https://github.com/Quansight/qhub/blob/main/qhub/template/%7B%7B%20cookiecutter.repo_directory%20%7D%7D/infrastructure/modules/kubernetes/services/jupyterhub/main.tf#L6. This still pins the chart to a particular version. Is there a reason that we are copying the entire chart locally? |
@costrouc I was following the example of what was done for the clearml integration (https://github.com/Quansight/qhub/tree/main/qhub/template/%7B%7B%20cookiecutter.repo_directory%20%7D%7D/infrastructure/modules/kubernetes/services/clearml), but I don't think there is anything preventing us from importing the chart. @aktech any thoughts for or against putting the entire helm chart in the repo? |
@Adam-D-Lewis I agree with @costrouc we shouldn't put helm charts in the repository. ClearML was a special case, as we had to modify the chart. Also, since the last update on ClearML, I'll see if we can remove the ClearML charts as well. |
❯ diff values-original.yaml values-monitoring-qhub.yaml
I made the requested changes. |
Waiting for the tests to pass here: #748 to see if the failed K8s tests in here are relevant or not. |
Seems like the tests pass on main, can you check why k8s tests fail? I can rerun again to confirm, |
Cyprus says there is insufficient cpu on the node with the additional pods in this PR. Maybe I can reduce the used cpu or maybe we can use CIrun |
Blocked by #756 |
b58c3ba
to
7cb1247
Compare
- move yaml to root - fix syntax - install python from miniconda - install node - install cypress dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your hard work on this @Adam-D-Lewis. This looks great to me. Looks perfect to me. Also excited to have a bigger CI for testing the Kubernetes cluster. This should allow out tests to be more comprehensive.
Could you add an entry to the changelog? |
Initial integration of prometheus/grafana into qhub. I tested it locally and it seems to be working. The kubernetes tests appear to be broken for an unrelated reason.