Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Failing due to CPU limits on Action Runners [bug] #756

Closed
Adam-D-Lewis opened this issue Aug 11, 2021 · 5 comments
Closed

CI Failing due to CPU limits on Action Runners [bug] #756

Adam-D-Lewis opened this issue Aug 11, 2021 · 5 comments
Labels
type: bug 🐛 Something isn't working

Comments

@Adam-D-Lewis
Copy link
Member

Adam-D-Lewis commented Aug 11, 2021

Github hosted action runners have 2 cores. With the latest PR adding Prometheus/Grafana to Qhub by default, the CI is failing because we are requesting ~2.5 cores from our minikube cluster, but as stated, we only have 2 cores.
#733

I want to try using CIRun (https://cirun.io/), as an alternative which allows us to spin up Action Runners of various sizes only as needed. @aktech do we have a Quansight account with access to CIRun?

@aktech
Copy link
Member

aktech commented Aug 11, 2021

the CI is failing because we are requesting ~2.5 cores from our minikube cluster

Ah interesting.

@aktech do we have a Quansight account with access to CIRun?

Yep we do have one via @quansight-bot

@Adam-D-Lewis
Copy link
Member Author

Amit let me know that some work has been done on this at https://github.com/aktech/qhub/tree/run-tests-cirun

@Adam-D-Lewis
Copy link
Member Author

Also, from Amit

Also, when you do that, I would suggest to move the kubernetes tests job to a separate file:
https://github.com/Quansight/qhub/blob/528bb850158d78d2eabdb561e1d37040052119a1/.github/workflows/test.yaml#L93

@Adam-D-Lewis
Copy link
Member Author

Adam-D-Lewis commented Aug 12, 2021

I'm waiting for a Quansight org owner to add the Cirun github app to the qhub repo

@aktech
Copy link
Member

aktech commented Aug 13, 2021

This was fixed here: 265d6c5

@aktech aktech closed this as completed Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants