Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conda-store-ui tests for updated page verbage #2911

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Jan 14, 2025

This PR fixes the broken conda-store ui tests which look for the Create Environment button. This button was renamed in conda-incubator/conda-store-ui#389 to just Create.

This test might have started breaking after updating conda-store from 2024.3.1 to 2024.11.1.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

@soapy1 soapy1 marked this pull request as ready for review January 14, 2025 18:37
@soapy1 soapy1 marked this pull request as draft January 14, 2025 18:47
@soapy1 soapy1 force-pushed the fix-cs-ui-test branch 4 times, most recently from 1f91204 to a59bfb0 Compare January 14, 2025 21:22
@soapy1 soapy1 marked this pull request as ready for review January 14, 2025 22:19
@marcelovilla
Copy link
Member

Closes #2908

Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @soapy1 🚀

@marcelovilla marcelovilla merged commit 062529b into nebari-dev:main Jan 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[BUG] - Local integration tests failing after upgrading the Jupyterlab extension for conda-store to 2024.11.1
2 participants