Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edge-case where k8s_version is equal to HIGHEST_SUPPORTED_K8S_VER… #1842

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Fix edge-case where k8s_version is equal to HIGHEST_SUPPORTED_K8S_VER… #1842

merged 2 commits into from
Jun 23, 2023

Conversation

iameskild
Copy link
Member

…SION

Reference Issues or PRs

Fixes #1840

What does this implement/fix?

Currently the comparison of "1.24.13-do.0" <= "1.24.13" (or HIGHEST_SUPPORTED_K8S_VERSION) fails. This is an edge case where the versions are indeed equal but the additional suffix (-do.0) causes it fail. This PR ensures that these kinds of comparisons won't fail.

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild requested a review from pavithraes June 23, 2023 12:38
pavithraes
pavithraes approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@pavithraes pavithraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me!

@pavithraes pavithraes added the status: approved 💪🏾 This PR has been reviewed and approved for merge label Jun 23, 2023
@pavithraes
Copy link
Member

pavithraes commented Jun 23, 2023 •
edited
Loading

The k8s tests failed. :/

@iameskild iameskild merged commit f4179dc into develop Jun 23, 2023
@iameskild iameskild deleted the fix_1840 branch June 23, 2023 14:05
@iameskild iameskild added this to the Release 2023.7.1 milestone Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavithraes pavithraes pavithraes approved these changes

Assignees
No one assigned
Labels
area: CI/CD 👷🏽‍♀️ area: k8s ⎈ status: approved 💪🏾 This PR has been reviewed and approved for merge
Projects
🪴 Nebari Project Management
Archived in project
Milestone
Release 2023.7.1
Development

Successfully merging this pull request may close these issues.

[BUG] - Nebari-CLI returns an error when using DigitalOcean initialization
2 participants
@iameskild @pavithraes