Skip to content

Commit

Permalink
Fix edge-case where k8s_version is equal to HIGHEST_SUPPORTED_K8S_VER… (
Browse files Browse the repository at this point in the history
  • Loading branch information
iameskild authored Jun 23, 2023
1 parent a6d032f commit f4179dc
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-provider.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -149,4 +149,4 @@ jobs:
PROVIDER: ${{ matrix.provider }}
CICD: ${{ matrix.cicd }}
with:
filename: .github/failed-workflow-issue-templates/provider-tests.md
filename: .github/failed-workflow-issue-templates/test-provider.md
2 changes: 1 addition & 1 deletion src/_nebari/provider/cloud/commons.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
def filter_by_highest_supported_k8s_version(k8s_versions_list):
filtered_k8s_versions_list = []
for k8s_version in k8s_versions_list:
if k8s_version <= HIGHEST_SUPPORTED_K8S_VERSION:
if k8s_version.split("-")[0] <= HIGHEST_SUPPORTED_K8S_VERSION:
filtered_k8s_versions_list.append(k8s_version)
return filtered_k8s_versions_list

0 comments on commit f4179dc

Please sign in to comment.