Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action to sync release notes with nebari-docs #1554

Merged
merged 6 commits into from
Nov 30, 2022
Merged

Action to sync release notes with nebari-docs #1554

merged 6 commits into from
Nov 30, 2022

Conversation

pavithraes
Copy link
Member

@pavithraes pavithraes commented Nov 18, 2022 •
edited
Loading

Reference Issues or PRs

Closes nebari-dev/nebari-docs#160

Supersedes #1502

The same action we're using in nebari-dev/.github to sync org-wide files like the license and issue templates.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

pavithraes and others added 5 commits November 15, 2022 15:11
@pavithraes
Add Note about QHub->Nebari rename in old docs (nebari-dev#1543)
247b8e5
@nebari-sensei
🔄 Synced file(s) with nebari-dev/.github (nebari-dev#1550)
21db764 
* 🔄 Synced local '.github/ISSUE_TEMPLATE/' with remote '.github/ISSUE_TEMPLATE/'

MAINT - Sync .github files 🤖

* 🔄 Synced local 'LICENSE' with remote 'LICENSE'

MAINT - Sync .github files 🤖

* 🔄 Synced local 'CONTRIBUTING.md' with remote 'CONTRIBUTING.md'

MAINT - Sync .github files 🤖

* 🔄 Synced local '.github/ISSUE_TEMPLATE/bug-report.yml' with remote '.github/ISSUE_TEMPLATE/bug-report-nebari.yml'

MAINT - Sync .github files 🤖

* 🔄 Synced local '.github/PULL_REQUEST_TEMPLATE.md' with remote '.github/PULL_REQUEST_TEMPLATE_simple.md'

MAINT - Sync .github files 🤖

Co-authored-by: nebari-sensei <null>
@nebari-sensei
🔄 Synced file(s) with nebari-dev/.github (nebari-dev#1551)
cab1c3b 
MAINT - Sync .github files 🤖

Co-authored-by: nebari-sensei <null>
@pavithraes
action to sync release notes with nebari-docs
0f2c011
@pavithraes
update RELEASE.md headers, add note about qhub
7d1fc6d
pavithraes
pavithraes commented Nov 18, 2022
View reviewed changes
.github/workflows/release-notes-sync.yaml
- name: Run Release File Sync ♻️
uses: BetaHuhn/repo-file-sync-action@v1
with:
GH_PAT: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member Author

@pavithraes pavithraes Nov 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does secrets.GITHUB_TOKEN have permission to nebari-dev/nebari-docs?
If not, do we need a new secret for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but we can update this in the future should it fail 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iameskild Looks like it doesn't have access, ref: https://github.com/nebari-dev/nebari/actions/runs/3597037385/jobs/6058376405#step:3:15

I see we use secrets.GH_PAT in nebari-dev/.github -- @trallard is this secrets.GH_PAT an org-level secret that we can use here? If not, we can create a new secret with the required scope.

@pavithraes pavithraes added type: maintenance 🛠 Day-to-day maintenance tasks type: release 🏷 Items related to Nebari releases area: community 🪴 labels Nov 18, 2022
@pavithraes pavithraes requested a review from kcpevey November 18, 2022 12:24
@pavithraes pavithraes mentioned this pull request Nov 23, 2022
Merged
18 tasks
@iameskild iameskild changed the base branch from main to release/2022.11.1 November 24, 2022 00:48
@pavithraes pavithraes requested a review from iameskild November 30, 2022 12:25
iameskild
iameskild approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@iameskild iameskild left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @pavithraes! Once the merge conflicts are resolved, this can be merged :)

.github/workflows/release-notes-sync.yaml
- name: Run Release File Sync ♻️
uses: BetaHuhn/repo-file-sync-action@v1
with:
GH_PAT: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but we can update this in the future should it fail 👍

@iameskild iameskild added this to the Release 2022.11.1 milestone Nov 30, 2022
@iameskild iameskild merged commit d785432 into nebari-dev:release/2022.11.1 Nov 30, 2022
@pavithraes pavithraes deleted the release-notes-sync branch April 25, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iameskild iameskild iameskild approved these changes

@kcpevey kcpevey Awaiting requested review from kcpevey

Assignees
No one assigned
Labels
area: community 🪴 type: maintenance 🛠 Day-to-day maintenance tasks type: release 🏷 Items related to Nebari releases
Projects
None yet
Milestone
Release 2022.11.1
Development

Successfully merging this pull request may close these issues.

[DOC] - add release notes
3 participants
@pavithraes @iameskild @nebari-sensei