-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release process reference guide #230
Conversation
✅ Deploy Preview for nebari-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@trallard @pavithraes I moved the release process doc to the community section and updated the Gitflow section to reflect what we discussed during the Nebari sync. |
Left several comments here, stuff that I think is missing:
From the checklist
|
The actual release notes are recorded at: https://github.com/nebari-dev/nebari/blob/release/2022.11.1/RELEASE.md We want to copy these to: https://www.nebari.dev/docs/references/RELEASE I do have a PR open to copy these over automatically on each release: nebari-dev/nebari#1554 |
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Thanks for the review @trallard! I believe I addressed all of the concerns above.
We don't need to manually create any tags as it is handled by GitHub's release process (which is where we link to) :) |
Thanks for working on this page, Eskild. I think it's looking great! |
@trallard @pavithraes as I have been writing up these docs and trying to think through how (existing and new) contributors will likely work, I'm starting to have some reservations about the Bokeh style gitflow workflow. There are a few places where this gitflow workflow is not entirely intuitive and will likely cause some confusion. A few examples of this include:
I'm not trying to drag this discussion out but I think it's worth making this process as simple and as intuitive as possible for the sake of all devs (existing and new alike). |
@iameskild Thank you for raising these great points! I'm on board with your original proposal involving the Bokeh's strategy does indeed add a couple of extra hoops for new contributors, and to combat that we've tried to make the process clear in our contributing guide. However, Bokeh also does significantly fewer releases (definitely not one per month!) which makes this much more manageable. |
Hey @pavithraes and @trallard, I have updated these docs based on the discussion we had last week around switching from Bokeh-style gitflow to Gitlab-style gitflow. This is ready for a final review. Once this is merged, I will make the requisite changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some comments and changes that need to be addressed before merging this @iameskild
It seems your branch is now out of sync with main
- so you will need to bring these in sync and move the release guide to the corresponding maintainer's section.
Edit: it does not seem to be out of sync but the file still needs moving and the sidebar needs update
@@ -0,0 +1,68 @@ | |||
--- | |||
id: release-process-branching-strategy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since I cannot leave comments on files names - this needs to be under docs/community/maintainers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this, @iameskild!
My only major suggestion -- I think we can move this page to the "Community/Maintainers" section, which might be a better fit. :)
The content looks complete though, so I'll approve and you can self-merge after!
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
Co-authored-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>
@trallard @pavithraes thanks for the feedback! I think this is finally ready :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @iameskild this looks great. Will go ahead and merge.
Reference Issues or PRs
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?