Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout/attempts for keycloak check #1023

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Conversation

viniciusdc
Copy link
Contributor

Fixes #1022

Increasing the number of attempts and timeout for checking if the keycloak server is in a running state might solve the flacky tests.

Changes:

  • Increase number of attempts and timeout condition for requesting access to keycloak admin URI

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

@viniciusdc viniciusdc requested a review from costrouc February 3, 2022 18:39
@costrouc costrouc merged commit da424e8 into main Feb 3, 2022
@costrouc costrouc deleted the fix-1022-tests branch February 3, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Fix flacky checks in qhub/deploy.py
2 participants