Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix flacky checks in qhub/deploy.py #1022

Closed
costrouc opened this issue Feb 3, 2022 · 1 comment · Fixed by #1023
Closed

[bug] Fix flacky checks in qhub/deploy.py #1022

costrouc opened this issue Feb 3, 2022 · 1 comment · Fixed by #1023

Comments

@costrouc
Copy link
Member

costrouc commented Feb 3, 2022

Describe the bug

The CI is still occasionally failing when waiting for services to come up. Lets adjust the checks to run for a total of 1 minute.

Expected behaviour

No unexpected failing tests

Actual behaviour

Don't have enough prs to get a good idea of the failure rate but we have seen 1 so far.

How to reproduce

@viniciusdc
Copy link
Contributor

viniciusdc commented Feb 3, 2022

The issue might be related to getting keycloak-server pod in a running state... we can also easily add a null_resource to wait a certain amount of time right after the helm resource is deployed. But I am not sure if that would be sufficient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants