feat(frontend): Expose whole pools list #661

shelegdmitriy · 2021-06-15T13:37:16Z

Particulary resolves #646

Test Plan:

Manualy check validators metrics;
Update existing tests

render · 2021-06-15T13:37:19Z

Your Render PR Server URL is https://near-explorer-frontend-with-indexer-pr-5l2p.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-c34aq3bpekqod0qg9io0.

frol · 2021-07-29T10:53:00Z

The table does not fit and has a horizontal scroll

Ideas:

Shrink the Stake column by only showing NEAR amounts without any fractional part
Shrink some other columns

The page is super slow

I feel it does too much re-renders, my browser (Firefox) is barely responsive on the page.

The telemetry data is missing

Add a tooltip to the flags to display the country name

It is not realistic that people would know all the flags by heart.

shelegdmitriy · 2021-08-02T14:25:43Z

@frol Hey Vlad! I have finished issues above except of "The telemetry data is missing" because it wasn't reproduced. On my local machine all data is available

frol · 2021-08-02T14:50:18Z

"The telemetry data is missing"

Oh, my bad, indeed 🤦

frol · 2021-08-06T15:52:16Z

@shelegdmitriy The page performance is now reasonable, great job!

We need to address the following:

Display staked values truncated to the whole NEAR amount [no fractional part]
Fix the validators that have no status:
Fix unit tests (it seems that we just need to update the snapshot)
Check if e2e tests pass on your local machine since nodes list test cannot pass on CI since you updated the backend

frontend/src/components/nodes/ValidatorMainRow.tsx

frontend/src/components/nodes/ValidatorMetadataRow.tsx

frontend/src/components/nodes/ValidatorTelemetryRow.tsx

shelegdmitriy · 2021-08-16T14:43:41Z

frontend/src/translations/vi.global.json

@@ -101,13 +101,17 @@
  "component": {
    "nodes": {
      "Validators": {
+        "location": "Location",


Need to translate

shelegdmitriy · 2021-08-16T14:44:15Z

frontend/src/translations/vi.global.json

-          "pending": {
-            "title": "Đang chờ",
+          "proposal": {
+            "title": "Proposal",


Need to translate title, explain text will be same

shelegdmitriy · 2021-08-16T14:44:56Z

frontend/src/translations/vi.global.json

+            "title": "Idle",
+            "text": "idle node"


Need to translate

shelegdmitriy · 2021-08-16T14:45:45Z

frontend/src/translations/vi.global.json

+      "ValidatorTelemetryRow": {
        "uptime": {
-          "title": "Uptime",
-          "text": "Uptime is estimated by the ratio of the number of produced blocks to the number of expected blocks"
+          "text": "Uptime is estimated by the ratio of the number of produced blocks to the number of expected blocks.",
+          "title": "Uptime"
        },
-        "latest_block": {
-          "title": "Latest block",
-          "text": "The block height the validation node reported in the most recent telemetry heartbeat."
+        "latest_produced_block": {
+          "text": "The block height the validation node reported in the most recent telemetry heartbeat.",
+          "title": "Latest block"
        },
        "latest_telemetry_update": {
-          "title": "Latest Telemetry Update",
-          "text": "Telemetry is a regular notification coming from the nodes which includes generic information like the latest known block height, and the version of NEAR Protocol agent (nearcore)."
+          "text": "Telemetry is a regular notification coming from the nodes which includes generic information like the latest known block height, and the version of NEAR Protocol agent (nearcore).",
+          "title": "Latest Telemetry Update"
        },
        "node_agent_name": {
-          "title": "Node Agent Name",
-          "text": "NEAR Protocol could have multiple implementations, so agent is the name of that implementation, where 'near-rs' is <a href=\"https://github.com/near/nearcore\">the official implementation</a>. "
+          "text": "NEAR Protocol could have multiple implementations, so agent is the name of that implementation, where 'near-rs' is ${agent_name_url}.",
+          "url_text": "the official implementation",
+          "title": "Node Agent Name"
        },
        "node_agent_version_or_build": {
          "title": "Node Agent Version / Build"
-        },
-        "warning_tip": "Các node xác thực 1 - ${node_tip_max} đang tích lũy stake trên 33%. Việc ký gửi cho những node xác thực bên dưới sẽ cải thiện tính phân tán cho mạng lưới."
+        }
+      },
+      "ValidatorMetadataRow": {
+        "pool_info": {


Need to translate

shelegdmitriy · 2021-08-16T14:46:17Z

frontend/src/translations/zh-hans.global.json

@@ -101,13 +101,17 @@
  "component": {
    "nodes": {
      "Validators": {
+        "location": "Location",


Need to translate

shelegdmitriy · 2021-08-16T14:46:32Z

frontend/src/translations/zh-hans.global.json

-          "pending": {
-            "title": "待定",
+          "proposal": {
+            "title": "Proposal",


Need to translate only title

shelegdmitriy · 2021-08-16T14:47:07Z

frontend/src/translations/zh-hans.global.json

+          "idle": {
+            "title": "Idle",
+            "text": "idle node"
          }
        },
+        "same_proposed_stake": "same"


Need to translate

shelegdmitriy · 2021-08-16T14:47:22Z

frontend/src/translations/zh-hans.global.json

+      "ValidatorMetadataRow": {
+        "pool_info": {
+          "website": "Web",
+          "email": "Email",
+          "twitter": "Twitter",
+          "discord": "Discord",
+          "description": "Description"
+        },
+        "pool_info_tip": {
+          "text": "If you are node owner feel free to fill all ${pool_info_url} to promote your own node!",
+          "url_text": "data"
+        }


Need to translate

frol · 2021-08-16T21:57:30Z

frontend/src/components/nodes/ValidatorsList.tsx

+    validatorsList.some((validator: N.ValidationNodeInfo, index: number) =>
+      totalStake &&
+      validator.cumulativeStakeAmount &&
+      validator.cumulativeStakeAmount.gt(totalStake.divn(3))
+        ? (validatorsList[index].networkHolder = true)
+        : false
+    );


Let's not abuse some here (mutations inside some callback function is a way to shoot your leg). In fact, I don't see a need for this networkHolder flag since you can move this whole condition right to the component render stage.

frol · 2021-08-18T07:40:53Z

frontend/src/components/nodes/ValidatorTelemetryRow.tsx

+      Boolean(agentVersion) ||
+      Boolean(agentBuild);
+
+    if (isTelemetryAvailable) return null;


Suggested change

if (isTelemetryAvailable) return null;

if (!isTelemetryAvailable) return null;

frol · 2021-08-18T07:42:12Z

frontend/src/components/nodes/ValidatorsList.tsx

+        : false
+    );
+
+    // console.log(validatorsList);


Let's clean it up

frol

@shelegdmitriy Well done! Thanks for improving the code clarity and getting through all the subtle details that are super important for the clear picture and improves visibility of the validators network!

shelegdmitriy requested a review from frol June 15, 2021 13:37

shelegdmitriy self-assigned this Jun 15, 2021

shelegdmitriy force-pushed the feat/expose_pools_list branch from ed92d43 to f7d342a Compare June 25, 2021 08:09

shelegdmitriy marked this pull request as ready for review June 25, 2021 12:14

shelegdmitriy force-pushed the feat/expose_pools_list branch from 2cccbcb to 8dad62e Compare June 25, 2021 12:17

shelegdmitriy force-pushed the feat/expose_pools_list branch 3 times, most recently from f1b5627 to 852601f Compare July 21, 2021 07:25

shelegdmitriy force-pushed the feat/expose_pools_list branch 2 times, most recently from 4640b54 to ef21314 Compare July 29, 2021 07:53

shelegdmitriy force-pushed the feat/expose_pools_list branch from 493cf64 to a7ccb82 Compare August 2, 2021 14:26

shelegdmitriy force-pushed the feat/expose_pools_list branch 2 times, most recently from 16366d9 to f01e7da Compare August 5, 2021 09:13

frol suggested changes Aug 12, 2021

View reviewed changes

shelegdmitriy force-pushed the feat/expose_pools_list branch from adf5404 to 72eef76 Compare August 13, 2021 16:10

shelegdmitriy added 10 commits August 16, 2021 16:37

feat(frontend): Resolve conflicts

0e45896

Expose validators and proposals into one tab

c9b3839

Merge 'Validators' and 'Proposals' and 'Pools' into single tab

999d39b

Cleanup and update tests

8832859

Fix failing test

09c181a

Extend information about validators

931edf0

Update test snapshots

be0e666

Cleanup

d96431d

Update snapshots

c0efc4b

Fix unnecessary re-render

cac3f65

shelegdmitriy added 7 commits August 16, 2021 16:56

Trying to increase page load speed

2a9f55a

Refactor to increase performance

f7f2ea5

Display validator's stake without fractional part

f5548aa

Cleanup and add 'Inactive' label for regular pool account

a7538f3

Move plain text to translation files

9581ae5

Copy i18n support from #706

1e705f9

Cleanup

b7c4efb

shelegdmitriy force-pushed the feat/expose_pools_list branch from 277c950 to b7c4efb Compare August 16, 2021 14:36

shelegdmitriy commented Aug 16, 2021

View reviewed changes

frol approved these changes Aug 16, 2021

View reviewed changes

Cleanup and update tests

aa1530c

shelegdmitriy force-pushed the feat/expose_pools_list branch from 84620bc to aa1530c Compare August 18, 2021 06:23

frol suggested changes Aug 18, 2021

View reviewed changes

Split 'stake' to 'currentStake' and 'proposedStake'

6d5aefd

frol approved these changes Aug 18, 2021

View reviewed changes

frol merged commit 95604a2 into master Aug 18, 2021

frol deleted the feat/expose_pools_list branch August 18, 2021 18:07

This was referenced Aug 18, 2021

Implement "Online" tab on the Nodes page #654

Closed

Node and Validator Epic #549

Closed

[BUG] NearBalance is misformatted on Stats page #707

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(frontend): Expose whole pools list #661

feat(frontend): Expose whole pools list #661

shelegdmitriy commented Jun 15, 2021 •

edited

Loading

render bot commented Jun 15, 2021

frol commented Jul 29, 2021

shelegdmitriy commented Aug 2, 2021

frol commented Aug 2, 2021

frol commented Aug 6, 2021 •

edited

Loading

shelegdmitriy Aug 16, 2021

shelegdmitriy Aug 16, 2021

shelegdmitriy Aug 16, 2021

shelegdmitriy Aug 16, 2021

shelegdmitriy Aug 16, 2021

shelegdmitriy Aug 16, 2021

shelegdmitriy Aug 16, 2021

shelegdmitriy Aug 16, 2021

frol Aug 16, 2021

frol Aug 18, 2021

frol Aug 18, 2021

frol left a comment

	if (isTelemetryAvailable) return null;
	if (!isTelemetryAvailable) return null;

feat(frontend): Expose whole pools list #661

feat(frontend): Expose whole pools list #661

Conversation

shelegdmitriy commented Jun 15, 2021 • edited Loading

Test Plan:

render bot commented Jun 15, 2021

frol commented Jul 29, 2021

The table does not fit and has a horizontal scroll

The page is super slow

The telemetry data is missing

Add a tooltip to the flags to display the country name

shelegdmitriy commented Aug 2, 2021

frol commented Aug 2, 2021

frol commented Aug 6, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

frol left a comment

Choose a reason for hiding this comment

shelegdmitriy commented Jun 15, 2021 •

edited

Loading

frol commented Aug 6, 2021 •

edited

Loading