Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

Validator nodes screen is confusing #646

Closed
ilblackdragon opened this issue May 28, 2021 · 6 comments · Fixed by #657 or #661
Closed

Validator nodes screen is confusing #646

ilblackdragon opened this issue May 28, 2021 · 6 comments · Fixed by #657 or #661
Assignees
Labels
bug Something isn't working Priority 1

Comments

@ilblackdragon
Copy link
Member

Details

Screen Shot 2021-05-28 at 4 16 06 AM

  1. Validator account names are not full even though they are short. "staked.poolv1.near..." is especially funny, what's behind ... where?
  2. key "ed25519... " shown doesn't make any sense. Also it leads to... transaction details of non existent transaction?
  3. Why 12 validators per page? We only have 60, they all can be shown on single page. Ideally just let's show all validators on one page until this becomes an issue. All other tools (https://near.zavodil.ru/?pools=) show on a single page fine.
  4. https://explorer.near.org/nodes/proposals page doesn't really make sense to me. It shows all the validator that got more delegations together with new validators? I would merge new validators into the list of validators and mark them "new". Not sure if we want to show validators who received more or less delegation but given there is also reward there, would need to query actual transactions to the contract to determine how much was staked / unstaked.
  5. Did we sunset the geo map? Is there plan to return it?
  6. It would be good to see also not currently validating nodes that are running with staking contract - for people who want to delegate to new nodes, that will be the only to find them given they don't show up in the wallet.

Steps to reproduce

  1. Go to https://explorer.near.org/nodes/validators and https://explorer.near.org/nodes/proposals
@frol frol added bug Something isn't working Priority 1 labels May 28, 2021
@frol
Copy link
Collaborator

frol commented May 29, 2021

  1. Did we sunset the geo map? Is there plan to return it?

The new design of the map turned the old map implementation useless, and given that it is a separate effort, I decided to go without it first.

All the rest items are valid concerns and we will address them asap

frol added a commit that referenced this issue Jun 7, 2021
Partially address #646.

# Test Plan

* [x] existing tests pass without changes
* [x] the page displays all the current validators on mainnet (59) on a single page
* [x] the regular updates do not crash CPU (without the change in the Context, it did x4 more re-renders since each individual state dispatch triggered re-render)
@frol
Copy link
Collaborator

frol commented Jun 8, 2021

Re No.4: Let's sunset the proposals tab and merge the current validators set, the next validators set, and the proposal into a single list using the label ("Active", "Kicked Out", "Next Epoch", "Proposal") to distinguish them.

Notes:

  • "Active" is the validator that is present in the current AND the next validators set
  • "Leaving" is the validator that is present in the current, but IS NOT part of the next validators set
  • "Next Epoch" is the validator that is NOT present in the current, but IS part of the next validators set
  • "Proposal" is the validator that is NOT present in the current and IS NOT part of the next validators set
  • Count only the current stake of current validators ("active" and "leaving") for total stake and cumulative stake (the current computation is correct, so it should not be affected by introducing more validators on the list)

@frol
Copy link
Collaborator

frol commented Jun 8, 2021

@ilblackdragon Re No.6: Having a list of *.poolv1.near accounts on the page would not help me to make any decision on whether I want or don't want to delegate to them. Pools advertisements should probably happen somewhere outside of Explorer, WDYT?

@ilblackdragon
Copy link
Member Author

ilblackdragon commented Jun 8, 2021 via email

@frol
Copy link
Collaborator

frol commented Jun 18, 2021

It was only addressed partially, so I reopen it now.

@frol frol reopened this Jun 18, 2021
@frol frol closed this as completed in #661 Aug 18, 2021
@luixo
Copy link
Contributor

luixo commented Apr 22, 2022

To increase connectivity of the repository, current validators refactoring: #955

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.