Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix httplib API calls for empty body #126 #127

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Fix httplib API calls for empty body #126 #127

merged 4 commits into from
Dec 13, 2024

Conversation

fklebert
Copy link
Contributor

Changes

Adapted the httplib interface calls to correctly pass std::string() instead of nullptr, plus simplifications.

Affected use-cases

Threw an exception when POST, PUT, etc. was called with empty request object.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@josephbirkner
Copy link
Collaborator

Awesome 💯

@fklebert fklebert merged commit 2c31269 into master Dec 13, 2024
14 checks passed
@fklebert fklebert deleted the fix-httplib-interface branch December 13, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephbirkner josephbirkner josephbirkner approved these changes

@MisterGC MisterGC Awaiting requested review from MisterGC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fklebert @josephbirkner