Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: session - add all starkAppInit and starkAppExit states to the Session config to make them configurable #727

Closed
christophercr opened this issue Sep 27, 2018 · 1 comment · Fixed by #766

Comments

@christophercr
Copy link
Collaborator

christophercr commented Sep 27, 2018

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

We have a use case where this can be useful:

The showcase deployed in GithubPages shows immediately the "Initialization failed: could not fetch user profile." dialog since we have no mock backend deployed yet.
In this case we would need to modify the starkPreloadingStateName to show the DEV login page instead.

Expected behavior

The initialization and exit screens should be fully configurable by exposing all the different starkAppInit and starkAppExit states in the Session config passed to the Session Module.

Minimal reproduction of the problem with instructions

Run the showcase in PROD mode without running any local backend.

What is the motivation / use case for changing the behavior?

Fully configurable initialization and exit screens.

@SuperITMan
Copy link
Member

In the showcase > app.module.ts, you could remove the condition

if (env === "development) {
  return require(".. /.. /config/json-server/data.json");
}

And set the mockdata with this all the time.

@christophercr christophercr changed the title core: session - add all starkAppInit and starkAppExit states to the Session config to be configurable core: session - add all starkAppInit and starkAppExit states to the Session config to make them configurable Sep 28, 2018
@christophercr christophercr self-assigned this Oct 8, 2018
christophercr referenced this issue in christophercr/stark Oct 9, 2018
christophercr referenced this issue in christophercr/stark Oct 12, 2018
christophercr referenced this issue in christophercr/stark Oct 12, 2018
christophercr referenced this issue in christophercr/stark Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants