Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(stark-core): refactor logic to validate StarkSessionConfig to prevent Angular AOT error "Function calls are not supported in decorators" #799

Conversation

christophercr
Copy link
Collaborator

ISSUES CLOSED: #797

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #797 #727

What is the new behavior?

AOT Production build succeeds even if a session config object is passed to the SessionModule.forRoot().

Does this PR introduce a breaking change?

[ ] Yes
[X] No

…o prevent Angular AOT error "Function calls are not supported in decorators" in StarkSessionModule.forRoot()

ISSUES CLOSED: #797
@christophercr christophercr force-pushed the feature/fix-aot-session-module branch from 1573546 to ea8c18c Compare October 25, 2018 14:22
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 91.424% when pulling ea8c18c on christophercr:feature/fix-aot-session-module into ccade91 on NationalBankBelgium:master.

@christophercr christophercr added this to the 10.0.0-beta.1 milestone Oct 25, 2018
@christophercr christophercr merged commit c061045 into NationalBankBelgium:master Oct 25, 2018
@christophercr christophercr deleted the feature/fix-aot-session-module branch October 30, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: session - AOT build fails when a config object is passed to StarkSessionModule.forRoot()
2 participants