Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stark-core): allow customizing Login and Preloading states via the StarkSessionConfig #766

Conversation

christophercr
Copy link
Collaborator

ISSUES CLOSED: #727

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #727

What is the new behavior?

All "Init" and "Exit" states managed by the Stark Session module are configurable via the StarkSessionConfig object passed in the forRoot() method.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Took the change to re-generate the root package-lock.json file.

@christophercr christophercr force-pushed the feature/configurable-session-states branch from bce014f to f8112cb Compare October 12, 2018 11:41
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 91.32% when pulling f8112cb on christophercr:feature/configurable-session-states into 203eaf7 on NationalBankBelgium:master.

@SuperITMan SuperITMan merged commit 822dec2 into NationalBankBelgium:master Oct 19, 2018
@christophercr christophercr deleted the feature/configurable-session-states branch October 23, 2018 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: session - add all starkAppInit and starkAppExit states to the Session config to make them configurable
3 participants