Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: simplify karma configuration #1145

Closed
carlo-nomes opened this issue Feb 21, 2019 · 0 comments · Fixed by #1474
Closed

build: simplify karma configuration #1145

carlo-nomes opened this issue Feb 21, 2019 · 0 comments · Fixed by #1474
Assignees
@carlo-nomes
Labels
comp: qa
Milestone
10.0.0-rc.3

Comments

@carlo-nomes
Copy link
Collaborator

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

When configuring karma in stark-core / stark-ui a lot of boilerplate is required for dealing with transient dependencies eg:

resolve: {
		alias: {
			...
			"lodash-es/cloneDeep": "../stark-core/node_modules/lodash-es/cloneDeep.js",
			"lodash-es/findIndex": "../stark-core/node_modules/lodash-es/findIndex.js",
			"lodash-es/floor": "../stark-core/node_modules/lodash-es/floor.js",
			"lodash-es/get": "../stark-core/node_modules/lodash-es/get.js",
			...
		}
}

Also the merging of extended behaviour (from stark-testing/karma.conf.js ) has to be done manually.

Expected behavior

If possible this should be simplified.
@carlo-nomes carlo-nomes self-assigned this Feb 21, 2019
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 22, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
f8c2b82 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 22, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
2321f7a 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 22, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
f59e7a9 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 26, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
458e93f 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
@carlo-nomes carlo-nomes mentioned this issue Feb 27, 2019
Merged
3 tasks
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 27, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
857cc4e 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 27, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
ec4cc3d 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 27, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
4a0fe47 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 28, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
7ef11a0 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 28, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
66a7aba 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 28, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
5ddd402 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 28, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
927ca83 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 28, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
e0a3afb 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 4, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
d2e6575 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 21, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
216b014 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 21, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
9151734 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
@christophercr christophercr mentioned this issue Mar 22, 2019
Merged
3 tasks
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 27, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
05afa54 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 27, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
e12315f 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 27, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
1e53d5d 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 27, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
7d8b2e5 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
@SuperITMan SuperITMan added this to the 10.0.0-rc.1 milestone Jun 6, 2019
@christophercr christophercr mentioned this issue Jul 25, 2019
Merged
3 tasks
@SuperITMan SuperITMan modified the milestones: 10.0.0-rc.2, 10.0.0-rc.3 Oct 29, 2019
SuperITMan referenced this issue in SuperITMan/stark Jan 8, 2020
@SuperITMan
test(stark-all): simplify karma configuration in stark-* packages + s…
27b97a2 
…howcase

ISSUES CLOSED: #1145
SuperITMan referenced this issue in SuperITMan/stark Jan 8, 2020
@SuperITMan
test(stark-all): simplify karma configuration in stark-* packages + s…
16e15bb 
…howcase

ISSUES CLOSED: #1145
SuperITMan referenced this issue in SuperITMan/stark Jan 8, 2020
@SuperITMan
test(stark-all): simplify karma configuration in stark-* packages + s…
a5d69ba 
…howcase

ISSUES CLOSED: #1145
@SuperITMan SuperITMan mentioned this issue Jan 8, 2020
Merged
3 tasks
SuperITMan referenced this issue in SuperITMan/stark Jan 8, 2020
@SuperITMan
test(stark-all): simplify karma configuration in stark-* packages + s…
3866b7f 
…howcase

ISSUES CLOSED: #1145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlo-nomes carlo-nomes

Labels
comp: qa
Projects
None yet
Milestone
10.0.0-rc.3
Development

Successfully merging a pull request may close this issue.

test(stark-all): simplify karma configuration in stark-* packages + showcase SuperITMan/stark
3 participants
@christophercr @SuperITMan @carlo-nomes