Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(stark-all): simplify karma configuration in stark-* packages + showcase #1474

Merged

Conversation

SuperITMan
Copy link
Member

ISSUES CLOSED: #1145

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The custom karma configuration for packages is repeated in every stark packages (stark-core, stark-rbac, stark-ui). It's complex to maintain and require to change the Karma config in 3 locations, for now, everytime a change is needed.

The showcase contains useless custom aliases.

Issue Number: #1145

What is the new behavior?

Karma configurations for packages has been simplified and are written only once under "packages/karma.conf.js" and "packages/karma.conf.ci.js".

The showcase does not contain any custom aliases.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@SuperITMan SuperITMan force-pushed the bugfix/simplify-karma-config branch from a5d69ba to 3866b7f Compare January 8, 2020 11:51
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 94.066% when pulling 3866b7f on SuperITMan:bugfix/simplify-karma-config into 52ae6e0 on NationalBankBelgium:master.

Copy link
Contributor

@nicanac nicanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 👍

@nicanac nicanac merged commit beac12f into NationalBankBelgium:master Jan 9, 2020
@SuperITMan SuperITMan deleted the bugfix/simplify-karma-config branch January 20, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: simplify karma configuration
3 participants