Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: rollup - optimize rollup.config usage with functions #1129

Closed
carlo-nomes opened this issue Feb 12, 2019 · 1 comment
Closed

build: rollup - optimize rollup.config usage with functions #1129

carlo-nomes opened this issue Feb 12, 2019 · 1 comment
Assignees
@carlo-nomes
Labels
comp: build-main Main build comp: qa
Milestone
should

Comments

@carlo-nomes
Copy link
Collaborator

carlo-nomes commented Feb 12, 2019 •
edited
Loading

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[X] Optimisation
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

All external libraries need to be added one by one, each subpackage seperatly.

Expected behavior

Replace this with functions to automatically decide how they should be mapped.
@carlo-nomes carlo-nomes self-assigned this Feb 12, 2019
@christophercr christophercr changed the title Optimize rollup.config usage with functions build: rollup - optimize rollup.config usage with functions Feb 12, 2019
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 22, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
f8c2b82 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 22, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
2321f7a 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 22, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
f59e7a9 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 26, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
458e93f 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 27, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
857cc4e 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 27, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
ec4cc3d 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 27, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
4a0fe47 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 28, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
7ef11a0 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 28, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
66a7aba 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 28, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
5ddd402 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 28, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
927ca83 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Feb 28, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
e0a3afb 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 4, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
d2e6575 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 21, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
216b014 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 21, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
9151734 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 27, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
05afa54 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 27, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
e12315f 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 27, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
1e53d5d 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 27, 2019
@carlo-nomes
feat(build): add lodash es imports and lodash types
7d8b2e5 
  - added used modules to rollup globals (TODO: NationalBankBelgium#1129)
  - blacklisted `lodash-es` (use submodules instead)
  - added `karma-typescript-es6-transform` for transforming es6 dependencies
    - added workaround for monounity/karma-typescript#320 in `base.spec.ts` (stark-core, stark-ui, showcase, starter)
    - aliased all used lodash modules in karma.conf.js (TODO NationalBankBelgium#1145)
  - minor refactors

ISSUES CLOSED: NationalBankBelgium#150
@SuperITMan SuperITMan added this to the 10.1.0 milestone Jun 6, 2019
@carlo-nomes carlo-nomes mentioned this issue Jul 29, 2019
Merged
3 tasks
@christophercr
Copy link
Collaborator

christophercr commented Jul 30, 2019 •
edited
Loading

Closing this issue as it is obsolete now that we use ng-packagr to build the stark packages thanks to #1360

@christophercr christophercr modified the milestones: 10.1.0, should Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlo-nomes carlo-nomes

Labels
comp: build-main Main build comp: qa
Projects
None yet
Milestone
should
Development

No branches or pull requests
3 participants
@christophercr @SuperITMan @carlo-nomes