Reverse command and error counts #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were being copied to the telemetry packet backwards. Trivial fix.
skliper
approved these changes
Dec 2, 2019
|
CCB 20191204 - Reviewed and approved for IC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #25
Telemetry values were being copied to the telemetry packet backwards. Trivial fix.
Testing performed
Build code using SIMULATION=native and default config. Send a command to SAMPLE_APP and verify that the command counter, not the error counter, has incremented in the telemetry packet.
Expected behavior changes
The command and error counters are correct, not reversed
System(s) tested on:
Ubuntu 18.04 LTS, 64 bit
Contributor Info
Joseph Hickey, Vantage Systems, Inc.