Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "sample_app" should call into "sample_lib" #23

Closed
jphickey opened this issue Nov 20, 2019 · 0 comments · Fixed by #34
Closed

The "sample_app" should call into "sample_lib" #23

jphickey opened this issue Nov 20, 2019 · 0 comments · Fixed by #34
Assignees
@jphickey
Labels
enhancement New feature or request
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The sample_app only calls CFE functions; it does not call any OSAL, PSP, or additional library functions like a real app might do.

This makes a difference for Unit Testing. The framework should contain a useful example of UT for apps and libs (related to #21) and the example would be more useful if it called something other than CFE.

Describe the solution you'd like
The sample_app should invoke the SAMPLE_Function as provided in the example sample_lib library.

Describe alternatives you've considered
N/A

Additional context
This change would demonstrate two things:

  • demonstrate at runtime that the dynamic linking worked correctly for the libraries (i.e. an app can successfully call into a lib like it is supposed to)
  • demonstrate linking to the stubs provided by the library for unit testing

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Nov 20, 2019
jphickey added a commit that referenced this issue Nov 21, 2019
@jphickey
Fix #23: Invoke SAMPLE_Function as part of Process command
0c46f28 
The CFE framework sample/lab applications did not have any
example use-cases where a _library_ function was invoked.

For the FSW verification aspect, it is important to do
this at least in one place as it verifies that the
run-time linking is working properly, not just for
functions in the core image but also for dynamically
loaded libraries.

The unit test framework also needs to support this use
case, to demonstrate that it can link against the stub
provided by the library for the local UT.

This just simply adds a call to the "SAMPLE_Function"
provided by sample_lib to demonstrate this.
jphickey added a commit that referenced this issue Nov 21, 2019
@jphickey
Fix #23: Invoke SAMPLE_Function as part of Process command
43ec0b7 
The CFE framework sample/lab applications did not have any
example use-cases where a _library_ function was invoked.

For the FSW verification aspect, it is important to do
this at least in one place as it verifies that the
run-time linking is working properly, not just for
functions in the core image but also for dynamically
loaded libraries.

The unit test framework also needs to support this use
case, to demonstrate that it can link against the stub
provided by the library for the local UT.

This just simply adds a call to the "SAMPLE_Function"
provided by sample_lib to demonstrate this.
This was referenced Nov 21, 2019
Merged
Merged
@skliper skliper added the enhancement New feature or request label Nov 30, 2019
@skliper skliper added this to the 1.2.0 milestone Dec 30, 2019
skliper added a commit that referenced this issue Dec 30, 2019
@skliper
CCB 20191218: Merge #24 #27 #29 #31
36df88f 
Fix #23, #25, #28, #30
Reviewed and approved at 2019-12-18 CCB
@skliper skliper mentioned this issue Dec 31, 2019
Merged
@skliper skliper closed this as completed in 7c10e1a Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement New feature or request
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Integration Candidate 20191230 nasa/sample_app
2 participants
@jphickey @skliper