Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor build settings issues #2339

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Fix minor build settings issues #2339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f471758
Pass UNITIALIZED (no type) settings to prescan
LeStarch Oct 25, 2023
bc5bf0f
Fix default CMAKE settings with =
LeStarch Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmake/prescan.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ set(EXCLUDED_CACHE_VARIABLES
set(TYPES_DISALLOWED_LIST
INTERNAL
STATIC
UNINITIALIZED
)
# Directory in-which to build the prescan directory
set(PRESCAN_DIR "${CMAKE_BINARY_DIR}/prescan")
Expand Down
2 changes: 1 addition & 1 deletion cmake/settings/ini-to-stdio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def print_setting(setting: str, value: str = "", ending: str = ";"):
def print_list_settings(items: List[str]):
"""Print a list of settings of form SETTING=VALUE"""
for item in items:
splits = item.strip().split("=")
splits = item.strip().split("=", 1)
if splits[0] != "":
print_setting(*splits)

Expand Down