Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor build settings issues #2339

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Fix minor build settings issues #2339

merged 2 commits into from
Oct 25, 2023

Conversation

LeStarch
Copy link
Collaborator

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Fixes two small issues:

  1. The prescan sub build does not forward CLI arguments without :TYPE as these were type UNITIALIZED
  2. The CMAKE default settings option was not limited to one = split, and thus broke

@LeStarch LeStarch requested a review from thomas-bc October 25, 2023 00:47
thomas-bc
thomas-bc approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeStarch LeStarch merged commit a97ebf6 into nasa:devel Oct 25, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-bc thomas-bc thomas-bc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeStarch @thomas-bc