Add tests for the Time
class in Fw
#1736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
I added a few tests for the
Time
class in theFw
component.Rationale
There was a comment indicating the tests should check the
add
function, but no tests had been implemented.fprime/Fw/Time/test/ut/TimeTest.cpp
Lines 32 to 42 in 91c578e
Testing/Review Recommendations
The tests are pretty straight-forward, but I particularly gave attention to how I commented each test since I felt it could've used a little cleaning up.
Future Work
Apart from
add
I added tests for checking comparison logic, but if there are any other parts of the class that aren't covered here, it might be a good idea to test those parts as well.