Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type issue with Drv::LinuxSerialDriver #1346

Merged
merged 1 commit into from
Mar 25, 2022
Merged

type issue with Drv::LinuxSerialDriver #1346

merged 1 commit into from
Mar 25, 2022

Conversation

danjwait
Copy link
Contributor

Originating Project/Creator @danjwait
Affected Component Drv::LinuxSerialDriver
Affected Architectures(s) Linux
Related Issue(s) None
Has Unit Tests (y/n) No
Builds Without Errors (y/n) Yes
Unit Tests Pass (y/n) N/A
Documentation Included (y/n) N/A

Change Description

Modifying LinuxSerialDriver startReadThread() to agree on types

Rationale

Type mismatch Os::Task::TASK_DEFAULT are NATIVE_UINT_TYPE , but call was for NATIVE_INT_TYPE . Ref "type conversion error in LinuxSerialDriver/LinuxSerialDriver.hpp?" in Q&A

Testing/Review Recommendations

make change in startReadThread() to match the Os::Task::TASK_DEFAULT

Future Work

Presently running GpsApp w/ this change on RPi w/ a GPS waiting for lock; but it build for native (linux) and RPi without errors.

@LeStarch LeStarch self-requested a review March 25, 2022 02:15
@LeStarch
Copy link
Collaborator

TaskStatus start(const Fw::StringBase &name, taskRoutine routine, void* arg, NATIVE_UINT_TYPE priority = TASK_DEFAULT, NATIVE_UINT_TYPE stackSize = TASK_DEFAULT, NATIVE_UINT_TYPE cpuAffinity = TASK_DEFAULT, NATIVE_UINT_TYPE identifier = TASK_DEFAULT); //!< start the task

@LeStarch
Copy link
Collaborator

The non-deprecated signature in "order priority, stack, affinity" matches the new order here. This is correct.

@LeStarch
Copy link
Collaborator

Note: we still need to update TcpClient and TcpServer to follow the same pattern. This is still an awesome contribution, thanks!

@LeStarch LeStarch merged commit 26e78ef into nasa:devel Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants