type issue with Drv::LinuxSerialDriver #1346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Modifying LinuxSerialDriver startReadThread() to agree on types
Rationale
Type mismatch Os::Task::TASK_DEFAULT are NATIVE_UINT_TYPE , but call was for NATIVE_INT_TYPE . Ref "type conversion error in LinuxSerialDriver/LinuxSerialDriver.hpp?" in Q&A
Testing/Review Recommendations
make change in startReadThread() to match the Os::Task::TASK_DEFAULT
Future Work
Presently running GpsApp w/ this change on RPi w/ a GPS waiting for lock; but it build for native (linux) and RPi without errors.