-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Implement breadcrumbs component #13317
Merged
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
c206128
feat(design-system): Implemented breadcrumbs component
MiloradFilipovic 4a77617
✨ Implemented async hidden items loading
MiloradFilipovic 0424bd1
✨ Added slots
MiloradFilipovic 6be03e5
💄 Adding tags to story
MiloradFilipovic 683429c
💄 Implementing correct styles for medium variant
MiloradFilipovic 6d581a4
💄 Implementing styles for small variant
MiloradFilipovic b4a2b06
Merge branch 'master' into ADO-3176-breadcrumbs-component
MiloradFilipovic 0006162
🔨 Simplifying the component, adding skeletons loading
MiloradFilipovic 0bdab90
⚡Implementing small version loading state
MiloradFilipovic b8ee1fe
✅ Adding test and more props
MiloradFilipovic e3c7888
⚡Hidden items caching and minor refactoring
MiloradFilipovic e23a4a3
👕 Disabling async warning in storybook entry
MiloradFilipovic eb62cbe
💄 More customization options
MiloradFilipovic d7c9b2d
✨ Adding loading state to action toggle
MiloradFilipovic e9a9b4e
⚡Using action toggle instead of tooltip
MiloradFilipovic f7b9bf3
⚡Refactoring events, fixing spacing
MiloradFilipovic ef12997
⚡Adding itemSelected event
MiloradFilipovic 51bc787
🔨 Cleanup
MiloradFilipovic dcd5272
👌 Highlighting only current item
MiloradFilipovic c2f38da
👌 Implemented watch on hidden items & cache bust mechanism
MiloradFilipovic fd42fbd
👌 Simplifying component API by allowing promise
MiloradFilipovic 54867c6
✅ Updating tests and stories
MiloradFilipovic 432e3f8
👕 Removing unused imports
MiloradFilipovic 4528fbf
✨ Allowing ellipsis to show when there are no hidden items
MiloradFilipovic 1ad8c3e
👌 Simplify watch
MiloradFilipovic 585f6a3
⚡Adding more docs and stories
MiloradFilipovic 186a41c
refactor: dots in slot
RobTF9 666c907
✅ Adding tests
MiloradFilipovic 2aa2b25
Merge remote-tracking branch 'origin/ADO-3176-breadcrumbs-component' …
MiloradFilipovic a2160a9
💄 Update styles for ellipses
MiloradFilipovic 4054105
👌 Removing unused prop
MiloradFilipovic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry, I was just asking if this should be
hiddenItems: []
, but I guess this might get us a reference to the same object every time like in Python parameter defaults 😅There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we must use the function. In Vue, Object or array defaults must be returned from a factory function like this. I just though types array like this is cleaner