feat(editor): Implement breadcrumbs component #13317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
CharlieKolb
reviewed
Feb 17, 2025
packages/design-system/src/components/N8nBreadcrumbs/Breadcrumbs.vue
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/N8nBreadcrumbs/Breadcrumbs.vue
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/N8nBreadcrumbs/Breadcrumbs.vue
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/N8nBreadcrumbs/Breadcrumbs.vue
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/N8nBreadcrumbs/BreadCrumbs.test.ts
Outdated
Show resolved
Hide resolved
CharlieKolb
reviewed
Feb 18, 2025
packages/design-system/src/components/N8nBreadcrumbs/Breadcrumbs.vue
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/N8nBreadcrumbs/Breadcrumbs.vue
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/N8nBreadcrumbs/Breadcrumbs.vue
Outdated
Show resolved
Hide resolved
|
|
CharlieKolb
previously approved these changes
Feb 19, 2025
packages/design-system/src/components/N8nActionToggle/ActionToggle.vue
Outdated
Show resolved
Hide resolved
| @@ -33,7 +33,7 @@ const emit = defineEmits<{ | |||
| }>(); | |||
| const props = withDefaults(defineProps<Props>(), { | |||
| hiddenItems: () => [], | |||
| hiddenItems: () => new Array<PathItem>(), | |||
There was a problem hiding this comment.
Oh sorry, I was just asking if this should be hiddenItems: [], but I guess this might get us a reference to the same object every time like in Python parameter defaults 😅
There was a problem hiding this comment.
Ah, we must use the function. In Vue, Object or array defaults must be returned from a factory function like this. I just though types array like this is cleaner
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ADO-3176-breadcrumbs-component
|
| Run status |
|
| Run duration | 04m 45s |
| Commit |
|
| Committer | Milorad Filipovic |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
436
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
CharlieKolb
approved these changes
Feb 19, 2025
|
|
1 similar comment
|
|
|
✅ All Cypress E2E specs passed |
Closed
despairblue
pushed a commit
that referenced
this pull request
Feb 20, 2025
Co-authored-by: Rob Squires <robtf9@icloud.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Breadcrumbs component that will be used in upcoming folders feature. Should support two verisons (
smallandmedium) and hidden path items should support async loading.More details are in Figma linked to the Linear issue.
Related Linear tickets, Github issues, and Community forum posts
Closes ADO-3176
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)