Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sample with empty array get crash #12

Closed
kkazuo opened this issue Nov 20, 2014 · 2 comments
Closed

sample with empty array get crash #12

kkazuo opened this issue Nov 20, 2014 · 2 comments

Comments

@kkazuo
Copy link
Contributor

kkazuo commented Nov 20, 2014 

@[].sample;

is this a spec?

I'll feel more comfort if this returns nil.
@mxcl
Copy link
Owner

mxcl commented Nov 23, 2014

Shouldn’t crash, will fix.

@mxcl mxcl closed this as completed in ba3062d Nov 23, 2014
mxcl added a commit that referenced this issue Nov 23, 2014
@mxcl
Don’t crash if sample is called on @[]
bbb5eb2 
Fixes #12

Tag 11.0.1
@kkazuo
Copy link
Contributor Author

kkazuo commented Nov 24, 2014

Nice!
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mxcl @kkazuo