Don’t crash if sample is called on @[]

Fixes #12
mxcl · Nov 23, 2014 · ba3062d · ba3062d
1 parent 2b45ecd
commit ba3062d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/NSArray+sample.m b/NSArray+sample.m
@@ -3,8 +3,10 @@
 
 @implementation NSArray (YOLO)
 
-- (id)sample {   
-    return self[arc4random_uniform((u_int32_t)self.count)];
+- (id)sample {
+    return self.count == 0
+        ? nil
+        : self[arc4random_uniform((u_int32_t)self.count)];
 }
 
 @end
diff --git a/tests b/tests
@@ -592,6 +592,10 @@ int main() {
     });
 }
 
+- (void)testEmptySample {
+  XCTAssertNil(@[].sample);
+}
+
 @end
-Original file line number
+Diff line change
@@ Expand Up / @@ -592,6 +592,10 @@ int main() { @@
         });
     }
+    - (void)testEmptySample {
+      XCTAssertNil(@[].sample);
+    }
     @end
@@ Expand Down @@