Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/go v1.20.5 integration #5406

Merged
merged 52 commits into from
Aug 4, 2023
Merged

Conversation

iulianpascalau
Copy link
Contributor

Reasoning behind the pull request

  • migrating from go compiler v1.17.6 to go v1.20.5

Proposed changes

  • integration work to assure backwards compatibility

Testing procedure

  • standard system test
  • half-half system test
  • import-db system test

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (ade2adf) 77.57% compared to head (831d699) 77.61%.

❗ Current head 831d699 differs from pull request most recent head f73e0b1. Consider uploading reports for the commit f73e0b1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5406      +/-   ##
==========================================
+ Coverage   77.57%   77.61%   +0.04%     
==========================================
  Files         654      656       +2     
  Lines       86044    86205     +161     
==========================================
+ Hits        66745    66906     +161     
  Misses      14092    14092              
  Partials     5207     5207              
Impacted Files Coverage Δ
factory/network/networkComponents.go 74.60% <ø> (-0.40%) ⬇️
common/compatibility/quickSorter.go 100.00% <100.00%> (ø)
common/compatibility/sorter.go 100.00% <100.00%> (ø)
common/enablers/enableEpochsHandler.go 74.28% <100.00%> (+0.18%) ⬆️
common/enablers/epochFlags.go 92.25% <100.00%> (+0.08%) ⬆️
epochStart/metachain/validators.go 79.13% <100.00%> (+4.04%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iulianpascalau iulianpascalau marked this pull request as ready for review July 11, 2023 14:32
@iulianpascalau iulianpascalau merged commit 0a0bcee into master Aug 4, 2023
@iulianpascalau iulianpascalau deleted the feat/go-v1.20.5-integration branch August 4, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants