Deterministic sort on validators info #5409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
fix-backwards-compatibility-in-go-1205
to
feat/go-v1.20.5-integration
July 8, 2023 07:07
…-validators-info # Conflicts: # epochStart/metachain/validators_test.go
sasurobert
previously approved these changes
Jul 10, 2023
miiu96
previously approved these changes
Jul 10, 2023
bogdan-rosianu
previously approved these changes
Jul 10, 2023
| testCreateMiniblockBackwardsCompatibility(t, false, "./testdata/expected-legacy.data") | ||
| }) | ||
| t.Run("full deterministic mode", func(t *testing.T) { | ||
| //this will prevent from changes the deterministic algorithm as to not create future backwards compatibility issues |
There was a problem hiding this comment.
might rephrase: this will prevent changes to the deterministic algorithm and ensure the backward compatibility
There was a problem hiding this comment.
rephrased comment
056a257
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat/go-v1.20.5-integration #5409 +/- ##
===============================================================
- Coverage 77.64% 77.61% -0.04%
===============================================================
Files 656 656
Lines 86186 86205 +19
===============================================================
- Hits 66922 66908 -14
- Misses 14058 14091 +33
Partials 5206 5206
☔ View full report in Codecov by Sentry. |
AdoAdoAdo
approved these changes
Jul 11, 2023
sasurobert
approved these changes
Jul 11, 2023
miiu96
approved these changes
Jul 11, 2023
bogdan-rosianu
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?