Merge rc/v1.6.0 in feat/sync missing trie nodes 12 may #5241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added semi-integration test
- minor refactoring in storage package - reworked the IsInterfaceNil tests - moved stub, fixed comments & tests
# Conflicts: # trie/node_test.go
….04.03 Update master rc/v1.5.0 2023.04.03
…into unittests_for_factory_api # Conflicts: # factory/api/apiResolverFactory_test.go
…into unittests_factory_bootstrap # Conflicts: # factory/bootstrap/bootstrapComponents_test.go
…-in-import-db use normal PersisterTracker if processing mode is import db
Bump library versions
Fix rewards broadcast
Coverage for: api/gin + addressGroup
…into api_tests_p3 # Conflicts: # api/mock/facadeStub.go
Coverage for: networkGroup, nodeGroup, proofGroup, transactionGroup, validatorGroup, vmValuesGroup
…hb-v2 Fix seldom failing tests in hb v2
Coverage for: blockGroup, hardforkGroup, internalBlockGroup
termui: display if the node is full archive
Coverage for: factory/processing
…in-feat/sync-missing-trie-nodes-12-may # Conflicts: # errors/errors.go # factory/interface.go # factory/mock/stateComponentsHolderStub.go # factory/state/stateComponentsHandler_test.go # go.mod # go.sum # integrationTests/state/stateTrieSync/stateTrieSync_test.go # node/node_test.go # state/syncer/userAccountsSyncer.go # testscommon/components/default.go # testscommon/factory/stateComponentsMock.go # trie/node.go # trie/trieStorageManagerFactory_test.go # trie/trieStorageManager_test.go
raduchis
approved these changes
May 12, 2023
ssd04
approved these changes
May 12, 2023
ssd04
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?