Added semi-integration test #5123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5123 +/- ##
=======================================
Coverage 75.72% 75.72%
=======================================
Files 649 649
Lines 85408 85423 +15
=======================================
+ Hits 64672 64687 +15
Misses 15641 15641
Partials 5095 5095
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
raduchis
previously approved these changes
Mar 23, 2023
…add-semi-integration-test
raduchis
previously approved these changes
Mar 23, 2023
sasurobert
previously approved these changes
Mar 23, 2023
trie/node.go
Outdated
| @@ -119,7 +120,7 @@ func computeAndSetNodeHash(n node) ([]byte, error) { | |||
| func getNodeFromDBAndDecode(n []byte, db common.DBWriteCacher, marshalizer marshal.Marshalizer, hasher hashing.Hasher) (node, error) { | |||
| encChild, err := db.Get(n) | |||
| if err != nil { | |||
| log.Trace(common.GetNodeFromDBErrorString, "error", err, "key", n) | |||
| log.Warn(common.GetNodeFromDBErrorString, "error", err, "key", n, "stack trace", string(debug.Stack())) | |||
ee6bb31
raduchis
previously approved these changes
Mar 24, 2023
AdoAdoAdo
approved these changes
Mar 27, 2023
raduchis
approved these changes
Mar 27, 2023
sasurobert
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?