Feat/outport refactor #5142

ssd04 · 2023-03-31T09:26:46Z

Reasoning behind the pull request

Refactored the WebSocket driver. The new drivers now support sending messages marshaled with json marshaller or the gogo proto marshalled.
The new WebSocketHost implementation can run in mode server or client.

Proposed changes

The new WebSocket client/server implementation was moved to a separate repository: https://github.com/multiversx/mx-chain-communication-go/tree/main/websocket

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

was the PR targeted to the correct branch?
if this is a larger feature that probably needs more than one PR, is there a feat branch created?
if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

…-2023 Merge rc into outport 21 mar 2023

…nterface # Conflicts: # factory/processing/processComponents.go # go.mod # go.sum # outport/factory/outportFactory_test.go # outport/process/alteredaccounts/alteredAccountsProvider.go # outport/process/alteredaccounts/alteredAccountsProvider_test.go

…terface Refactor outport driver

Co-authored-by: Sorin Stanculeanu <34831323+sstanculeanu@users.noreply.github.com>

# Conflicts: # api/groups/blockGroup_test.go # factory/processing/export_test.go # factory/processing/processComponents_test.go # go.mod # go.sum # testscommon/components/components.go

New `web-sockets` connector

Merge rc 1 6 into outport3

codecov · 2023-05-18T11:59:33Z

Codecov Report

Patch coverage: 80.65% and project coverage change: +8.80 🎉

Comparison is base (135441f) 70.87% compared to head (f313116) 79.67%.

❗ Current head f313116 differs from pull request most recent head 5aa0ab3. Consider uploading reports for the commit 5aa0ab3 to get more accurate results

Additional details and impacted files

@@              Coverage Diff              @@
##           rc/v1.6.0    #5142      +/-   ##
=============================================
+ Coverage      70.87%   79.67%   +8.80%     
=============================================
  Files            664      685      +21     
  Lines          86187    88635    +2448     
=============================================
+ Hits           61081    70616    +9535     
+ Misses         20516    12852    -7664     
- Partials        4590     5167     +577

Impacted Files	Coverage Δ
api/middleware/responseLogger.go	`66.66% <0.00%> (ø)`
...termui/view/termuic/termuiRenders/widgetsRender.go	`2.94% <0.00%> (ø)`
common/channels.go	`100.00% <ø> (ø)`
common/configParser.go	`21.59% <0.00%> (-1.03%)`	⬇️
dataRetriever/storageRequesters/headerRequester.go	`93.50% <ø> (ø)`
epochStart/bootstrap/fromLocalStorage.go	`50.28% <0.00%> (-0.30%)`	⬇️
facade/initial/initialNodeFacade.go	`98.68% <ø> (+24.35%)`	⬆️
facade/nodeFacade.go	`97.25% <ø> (+18.42%)`	⬆️
factory/api/apiResolverFactory.go	`94.45% <ø> (+94.45%)`	⬆️
factory/bootstrap/bootstrapComponents.go	`91.89% <ø> (+91.89%)`	⬆️
... and 83 more

... and 144 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Latest indexer version

iulianpascalau · 2023-05-19T12:14:48Z

go.mod

@@ -13,10 +13,10 @@ require (
 	github.com/google/gops v0.3.18
 	github.com/gorilla/websocket v1.5.0
 	github.com/mitchellh/mapstructure v1.5.0
-	github.com/multiversx/mx-chain-communication-go v0.0.0-20230512095548-5bc637293104
-	github.com/multiversx/mx-chain-core-go v1.2.4-0.20230517135533-2e54a17cd912
+	github.com/multiversx/mx-chain-communication-go v1.0.0


iulianpascalau · 2023-05-19T12:15:22Z

go.mod

-	github.com/multiversx/mx-chain-communication-go v0.0.0-20230512095548-5bc637293104
-	github.com/multiversx/mx-chain-core-go v1.2.4-0.20230517135533-2e54a17cd912
+	github.com/multiversx/mx-chain-communication-go v1.0.0
+	github.com/multiversx/mx-chain-core-go v1.2.4


iulianpascalau · 2023-05-19T12:15:51Z

go.mod

 	github.com/multiversx/mx-chain-crypto-go v1.2.6
-	github.com/multiversx/mx-chain-es-indexer-go v1.4.2-0.20230518130444-97e3775aa0ff
+	github.com/multiversx/mx-chain-es-indexer-go v1.4.3


mariusmihaic and others added 30 commits March 14, 2023 14:12

FEAT: Refactor outport interface + stubs

1af4cdd

FEAT: Refactor outportDataProvider.go

fd9b838

FIX: Outport tests

70042f4

FIX: Refactor outport

a2a0589

FIX: Altered accounts

8ccc419

FIX: Accounts parser

906cd28

FIX: tx sorter

5eaa184

FIX: tx fee processor

578c7a5

FIX: Continue refactor

8c34b9b

FIX: Make solution build

35f1baf

FIX: Unit tests + build

88a089b

FIX: Unit tests

0f3f77e

FEAT: Change interfaces in outport and drivers

0836210

FIX: Unit tests

9aa2004

CLN: Move ConvertPubKeys to core

deb08fa

CLN: RevertIndexedBlock in notifier

b57002f

CLN: Event notifier

9854cb3

FIX: go.mod

b383d10

FIX: After self review

d2151a1

FEAT: Update go.mod

48acbd8

Merge pull request #5116 from multiversx/merge-rc-into-outport-21-mar…

3968d22

…-2023 Merge rc into outport 21 mar 2023

FIX: After merge

cd6bcd0

FIX: After merge 2

14fde5c

FIX: After review

1a37298

FIX: Revert logs map to slice

d51c048

Merge pull request #5097 from multiversx/MX-13968-refactor-outport-in…

956bdb8

…terface Refactor outport driver

add marshaller type for notifier to external config

9d6218f

fix unit tests for outport driver

df66015

Update cmd/node/config/external.toml

e154667

Co-authored-by: Sorin Stanculeanu <34831323+sstanculeanu@users.noreply.github.com>

miiu96 and others added 20 commits April 12, 2023 15:06

new commit hash

2ebe548

integrate new host

7aa5793

move host driver

42f28c7

latest version of communication go

d42c502

update mx-chain-core and communication go

908ff49

fix

48fa297

change comm go

72ffd89

change comm go

4d5cc99

fixes

ae1775f

fix

fc3828f

Merge branch 'rc/v1.6.0' into merge-rc-1-6-into-outport3

3e1988b

# Conflicts: # api/groups/blockGroup_test.go # factory/processing/export_test.go # factory/processing/processComponents_test.go # go.mod # go.sum # testscommon/components/components.go

FIX: After merge

fad08d2

FIX: After merge 2

0b2e12f

fix comment

a58411d

Merge pull request #5170 from multiversx/integrate-new-ws-client-server

20bf440

New `web-sockets` connector

FIX: Indexer

57f5f3c

Merge branch 'feat/outport-refactor' into merge-rc-1-6-into-outport3

38f8309

FIX: Unit test

b70a400

fixes after merge

f4460b5

Merge pull request #5249 from multiversx/merge-rc-1-6-into-outport3

c5e1070

Merge rc 1 6 into outport3

miiu96 and others added 3 commits May 18, 2023 16:08

latest indexer version

9b4dc71

proper tags

83c48f5

Merge pull request #5252 from multiversx/latest-indexer-version

5aa0ab3

Latest indexer version

miiu96 marked this pull request as ready for review May 19, 2023 11:48

gabi-vuls approved these changes May 19, 2023

View reviewed changes

bogdan-rosianu approved these changes May 19, 2023

View reviewed changes

iulianpascalau approved these changes May 19, 2023

View reviewed changes

miiu96 merged commit e921b57 into rc/v1.6.0 May 19, 2023

miiu96 deleted the feat/outport-refactor branch May 19, 2023 12:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/outport refactor #5142

Feat/outport refactor #5142

ssd04 commented Mar 31, 2023 •

edited by miiu96

Loading

codecov bot commented May 18, 2023 •

edited

Loading

iulianpascalau May 19, 2023

iulianpascalau May 19, 2023

iulianpascalau May 19, 2023

Feat/outport refactor #5142

Feat/outport refactor #5142

Conversation

ssd04 commented Mar 31, 2023 • edited by miiu96 Loading

Reasoning behind the pull request

Proposed changes

Pre-requisites

codecov bot commented May 18, 2023 • edited Loading

Codecov Report

iulianpascalau May 19, 2023

Choose a reason for hiding this comment

iulianpascalau May 19, 2023

Choose a reason for hiding this comment

iulianpascalau May 19, 2023

Choose a reason for hiding this comment

ssd04 commented Mar 31, 2023 •

edited by miiu96

Loading

codecov bot commented May 18, 2023 •

edited

Loading