Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest indexer version #5252

Merged
merged 2 commits into from
May 19, 2023
Merged

Latest indexer version #5252

merged 2 commits into from
May 19, 2023

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented May 18, 2023

Reasoning behind the pull request

  • Updated the version of the mx-chain-es-indexer-go module
  • Added proper tags

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

mariusmihaic
mariusmihaic previously approved these changes May 18, 2023
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 89.17% and project coverage change: +8.81 🎉

Comparison is base (3df9a57) 70.82% compared to head (2475007) 79.63%.

❗ Current head 2475007 differs from pull request most recent head 83c48f5. Consider uploading reports for the commit 83c48f5 to get more accurate results

Additional details and impacted files
@@                    Coverage Diff                    @@
##           feat/outport-refactor    #5252      +/-   ##
=========================================================
+ Coverage                  70.82%   79.63%   +8.81%     
=========================================================
  Files                        677      685       +8     
  Lines                      87941    88635     +694     
=========================================================
+ Hits                       62284    70588    +8304     
+ Misses                     20960    12882    -8078     
- Partials                    4697     5165     +468     
Impacted Files Coverage Δ
api/middleware/responseLogger.go 66.66% <0.00%> (ø)
cmd/keygenerator/converter/pidPubkeyConverter.go 90.47% <ø> (ø)
...termui/view/termuic/termuiRenders/widgetsRender.go 2.94% <0.00%> (-0.04%) ⬇️
common/channels.go 100.00% <ø> (ø)
common/configParser.go 21.59% <0.00%> (-1.03%) ⬇️
factory/bootstrap/bootstrapComponentsHandler.go 78.94% <0.00%> (+78.94%) ⬆️
factory/crypto/cryptoComponents.go 79.69% <ø> (+20.14%) ⬆️
factory/processing/blockProcessorCreator.go 81.88% <ø> (+81.88%) ⬆️
factory/processing/processComponents.go 82.60% <ø> (+82.60%) ⬆️
factory/processing/txSimulatorProcessComponents.go 75.70% <ø> (ø)
... and 64 more

... and 85 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@miiu96 miiu96 merged commit 5aa0ab3 into feat/outport-refactor May 19, 2023
@miiu96 miiu96 deleted the latest-indexer-version branch May 19, 2023 11:48
@schimih schimih added the ignore-for-release-notes Do not include item in release notes label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release-notes Do not include item in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants