Merge rc v1.4.0 in multisigner #4524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signature handler component for consensus
…osk-bls-multisigner Merge rc july into feat kosk bls multisigner
…nter-issue Fix linter issue: remove unused function
…snapshot-nodes # Conflicts: # common/interface.go # integrationTests/state/stateTrieSync/stateTrieSync_test.go # state/accountsDB.go # state/accountsDB_test.go # state/peerAccountsDB.go # state/peerAccountsDB_test.go # testscommon/storageManagerStub.go # testscommon/trie/trieStub.go # trie/patriciaMerkleTrie_test.go # trie/trieStorageManager.go # trie/trieStorageManagerWithoutCheckpoints.go # trie/trieStorageManagerWithoutCheckpoints_test.go # trie/trieStorageManagerWithoutPruning.go # trie/trieStorageManagerWithoutPruning_test.go # trie/trieStorageManager_test.go
# Conflicts: # update/factory/dataTrieFactory.go
rc/2022-july
…rc-v1.4.0 Update p2p separate repo rc v1.4.0
…refactor # Conflicts: # go.mod
refactor dataTrieTracker
v1.3.42-dev-config compatible configs
…rc-v1.4.0 Update separate p2p repo rc v1.4.0
New p2p version
Merge master rc v1.4.0
…ltisigner # Conflicts: # consensus/interface.go # consensus/spos/bls/subroundSignature.go # consensus/spos/errors.go # consensus/spos/subround_test.go # errors/errors.go # factory/crypto/cryptoComponents.go # factory/crypto/cryptoComponentsHandler.go # factory/crypto/cryptoComponents_test.go # factory/heartbeatV2Components_test.go # factory/mock/cryptoComponentsMock.go # integrationTests/consensus/testInitializer.go # integrationTests/mock/cryptoComponentsStub.go # integrationTests/testProcessorNode.go # node/mock/factory/cryptoComponentsStub.go # node/nodeTesting_test.go # p2p/crypto/p2pSigner.go # p2p/crypto/p2pSigner_test.go # p2p/libp2p/interface.go # p2p/libp2p/mockMessenger.go # p2p/libp2p/netMessenger.go # p2p/libp2p/netMessenger_test.go # p2p/p2p.go
sstanculeanu
previously approved these changes
Sep 28, 2022
AdoAdoAdo
reviewed
Sep 28, 2022
| continue | ||
| } | ||
|
|
||
| managedPrivateKeyBytes, err := managedPrivateKey.ToByteArray() |
There was a problem hiding this comment.
signature handler was supposed to do itself the management of private keys and signing and move that out of the consensus, but here it is partially moved into consensus again.
Maybe add a todo and I will do the refactor, or you can move the management into the signature handler.
| @@ -153,6 +153,7 @@ type ScheduledProcessor interface { | |||
| type SignatureHandler interface { | |||
| Reset(pubKeys []string) error | |||
| CreateSignatureShare(msg []byte, index uint16, epoch uint32) ([]byte, error) | |||
| CreateSignatureShareWithPrivateKey(message []byte, index uint16, epoch uint32, privateKeyBytes []byte) ([]byte, error) | |||
There was a problem hiding this comment.
this needs to be refactored to remove private key as parameter.
If you add a TODO I can do the refactor.
AdoAdoAdo
approved these changes
Sep 28, 2022
sstanculeanu
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the reasoning behind the pull request (what feature was missing / how the problem was manifesting itself / what was the motive behind the refactoring)
Proposed Changes
Testing procedure