Signature handler component for consensus #4316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- temporary mock for multisigner - unit tests - temp elrond-go-crypto version
Codecov Report
@@ Coverage Diff @@
## feat/kosk-bls-multisigner #4316 +/- ##
============================================================
Coverage ? 71.56%
============================================================
Files ? 666
Lines ? 86350
Branches ? 0
============================================================
Hits ? 61796
Misses ? 20142
Partials ? 4412 Continue to review full report at Codecov.
|
AdoAdoAdo
requested changes
Aug 1, 2022
…factor to specify the current epoch
- use priv key as bytes in signature handler component - rename stub name
AdoAdoAdo
requested changes
Aug 1, 2022
AdoAdoAdo
previously approved these changes
Aug 1, 2022
sstanculeanu
reviewed
Aug 1, 2022
sstanculeanu
previously approved these changes
Aug 2, 2022
sstanculeanu
previously approved these changes
Aug 2, 2022
AdoAdoAdo
requested changes
Aug 2, 2022
consensus/signing/signing.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| pubKeys := make([][]byte, 0) |
There was a problem hiding this comment.
since we have for example in metachain 400 in consensus group, this will cause a lot of re-allocations
maybe do
pubKeys := make([][]byte, 0, len(sh.data.pubKeys))
sstanculeanu
approved these changes
Aug 2, 2022
AdoAdoAdo
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a separate signature handler component for consensus, it is basically a wrapper over the new stateless multisigner from crypto. It keeps the associated public keys and signature shares used for consensus.