En 12318 gascost txs frozen #4159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/node/config/config.toml
Outdated
| @@ -66,6 +70,7 @@ | |||
| # it is a good idea to increase the maximum number of opened files allowed by the operating system | |||
| FullArchiveNumActivePersisters = 10 | |||
|
|
|||
|
|
|||
| log.Trace("creating economics data components") | ||
| argsNewEconomicsData := economics.ArgsNewEconomicsData{ | ||
| Economics: &ccf.economicsConfig, | ||
| PenalizedTooMuchGasEnableEpoch: ccf.epochConfig.EnableEpochs.PenalizedTooMuchGasEnableEpoch, | ||
| GasPriceModifierEnableEpoch: ccf.epochConfig.EnableEpochs.GasPriceModifierEnableEpoch, | ||
| EpochNotifier: epochNotifier, | ||
| BuiltInFunctionsCostHandler: builtInCostHandler, | ||
| TxVersionChecker: txVersionChecker, |
There was a problem hiding this comment.
a little strange why an "economics handler, whatever" depends upon the transaction version checker.
Understood why it has been done, not having a great suggestion if or how to refactor. Can be left as it is.
process/economics/economicsData.go
Outdated
| mutGasLimitSettings sync.RWMutex | ||
| gasPerDataByte uint64 | ||
| minGasPrice uint64 | ||
| extraGasLimitGuardedTx uint64 |
There was a problem hiding this comment.
move this also in gasConfig struct?
|
|
||
| args.EpochNotifier.RegisterNotifyHandler(ed) | ||
|
|
||
| return ed, nil | ||
| } | ||
|
|
||
| func (ed *economicsData) setGasLimitSetting(gasLimitSetting config.GasLimitSetting) error { |
There was a problem hiding this comment.
👍
remained as technical debt this refactor from our last change
iulianpascalau
approved these changes
Jun 20, 2022
raduchis
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an increase in the gas limit for guarded transactions, since there is extra processing for guardian signature verification.