En 12302 cosigned set guardian #4119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and add some unit tests
| @@ -66,6 +70,7 @@ | |||
| # it is a good idea to increase the maximum number of opened files allowed by the operating system | |||
| FullArchiveNumActivePersisters = 10 | |||
|
|
|||
|
|
|||
| return agc.saveAccountGuardians(accHandler, accountGuardians) | ||
| } | ||
|
|
||
| // TODO: add constraints on not co-signed txs on interceptor, for setGuardian |
There was a problem hiding this comment.
task for TODO?
Also, question: is there a check as to not send value on a setGuardian transaction call? (in builtin function implementation)
There was a problem hiding this comment.
Created a task: [EN-12365] for the TODO.
the check is for all related builtin functions: SetGuardian, FreezeAccount & UnfreezeAccount
The check is already done on checkBaseAccountFreezerArgs for all related builtin functions
if !isZero(vmInput.CallValue) {
return ErrBuiltInFunctionCalledWithValue
}
raduchis
reviewed
May 30, 2022
iulianpascalau
approved these changes
Jun 20, 2022
raduchis
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.