feat(multicodecs): add filecoin multicodecs #161
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -429,3 +429,8 @@ holochain-key-v0, holochain, 0x947124, Holochain v0 pub | |
| holochain-key-v1, holochain, 0x957124, Holochain v1 public key + 8 R-S (63 x Base-32) | ||
| holochain-sig-v0, holochain, 0xa27124, Holochain v0 signature + 8 R-S (63 x Base-32) | ||
| holochain-sig-v1, holochain, 0xa37124, Holochain v1 signature + 8 R-S (63 x Base-32) | ||
| fil-piece-unsealed, serialization, 0xfi01, Filecoin piece, raw data (CID = Piece Commitment) | ||
| fil-sector-unsealed, serialization, 0xfi02, Filecoin sector, raw data (CID = Data commitment) | ||
| fil-sector-sealed, serialization, 0xfi03, Filecoin sector, sealed and replicated (CID = Replication Commitment) | ||
| fil-hash-unsealed, multihash, 0xfi04, Filecoin unsealed commitment hash (custom hashing alg) | ||
| fil-hash-sealed, multihash, 0xfi05, Filecoin sealed commitment hash (custom hashing alg) | ||
|
There was a problem hiding this comment. What's the actual hashing algorithm? Or is this some kind of special merkle-tree based hash? There was a problem hiding this comment. according to @porcuquine, it is indeed custom. @porcuquine describes it as "SHA256 with a twist" -- different enough that he says it shouldn't just be SHA-256 |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the format of this data? CAR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be IPLD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's neither. The CID here is the root of the merkletree constructed from the bytes that make up the CAR.