Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multicodecs): add filecoin multicodecs #161

Closed
wants to merge 3 commits into from
Closed

feat(multicodecs): add filecoin multicodecs #161

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df5ec1b
feat(multicodecs): add filecoin multicodecs
hannahhoward Feb 7, 2020
6f7d5cc
fix(multicodec): remove non-hex character
hannahhoward Feb 7, 2020
22dcefb
fix(multicodec): fix csv formatting
hannahhoward Feb 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions table.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,3 +429,8 @@ holochain-key-v0, holochain, 0x947124, Holochain v0 pub
holochain-key-v1, holochain, 0x957124, Holochain v1 public key + 8 R-S (63 x Base-32)
holochain-sig-v0, holochain, 0xa27124, Holochain v0 signature + 8 R-S (63 x Base-32)
holochain-sig-v1, holochain, 0xa37124, Holochain v1 signature + 8 R-S (63 x Base-32)
fil-piece-unsealed, serialization, 0xf101, Filecoin piece- raw data (CID = Piece Commitment)
fil-sector-unsealed, serialization, 0xf102, Filecoin sector- raw data (CID = Data commitment)
fil-sector-sealed, serialization, 0xf103, Filecoin sector- sealed and replicated (CID = Replication Commitment)
Comment on lines +432 to +434
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the documentation available about the structure of all those ones? Are those really unique formats or just blobs of bytes? Multicodecs are for formats, not identifiers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hannahhoward the piece commitment and the data commitment should be the same, only need one of those

fil-hash-unsealed, multihash, 0xf104, Filecoin unsealed commitment hash (custom hashing alg)
fil-hash-sealed, multihash, 0xf105, Filecoin sealed commitment hash (custom hashing alg)