Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Replace ChangeEvent<{}> with SyntheticEvent #22716

Merged
merged 1 commit into from
Sep 24, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/pages/components/autocomplete/GitHubLabel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export default function GitHubLabel() {
};

const handleClose = (
event: React.ChangeEvent<{}>,
event: React.SyntheticEvent,
reason: AutocompleteCloseReason,
) => {
if (reason === 'toggleInput') {
Expand Down
4 changes: 2 additions & 2 deletions docs/src/pages/components/tree-view/ControlledTreeView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ export default function ControlledTreeView() {
const [expanded, setExpanded] = React.useState<string[]>([]);
const [selected, setSelected] = React.useState<string[]>([]);

const handleToggle = (event: React.ChangeEvent<{}>, nodeIds: string[]) => {
const handleToggle = (event: React.SyntheticEvent, nodeIds: string[]) => {
setExpanded(nodeIds);
};

const handleSelect = (event: React.ChangeEvent<{}>, nodeIds: string[]) => {
const handleSelect = (event: React.SyntheticEvent, nodeIds: string[]) => {
setSelected(nodeIds);
};

Expand Down
2 changes: 1 addition & 1 deletion framer/Material-UI.framerfx/code/Tabs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export function Tabs(props: Props): JSX.Element {

const [value, setValue] = React.useState(0);

const handleChange = (event: React.ChangeEvent<{}>, newValue: number) => {
const handleChange = (event: React.SyntheticEvent, newValue: number) => {
setValue(newValue);
};

Expand Down
2 changes: 1 addition & 1 deletion framer/scripts/templates/tabs.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const { appBarColor, labels, icons, width, height, ...other } = props

const [value, setValue] = React.useState(0);

const handleChange = (event: React.ChangeEvent<{}>, newValue: number) => {
const handleChange = (event: React.SyntheticEvent, newValue: number) => {
setValue(newValue);
};

Expand Down
4 changes: 2 additions & 2 deletions packages/material-ui-lab/src/Rating/Rating.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,14 @@ export interface RatingProps
* @param {object} event The event source of the callback.
* @param {number} value The new value.
*/
onChange?: (event: React.ChangeEvent<{}>, value: number | null) => void;
onChange?: (event: React.SyntheticEvent, value: number | null) => void;
/**
* Callback function that is fired when the hover state changes.
*
* @param {object} event The event source of the callback.
* @param {number} value The new value.
*/
onChangeActive?: (event: React.ChangeEvent<{}>, value: number) => void;
onChangeActive?: (event: React.SyntheticEvent, value: number) => void;
/**
* The minimum increment value change allowed.
* @default 1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,4 @@ function testOnChange() {
function handleElementChange(event: React.ChangeEvent) {}
// @ts-expect-error internally it's whatever even lead to a change in value
<Slider onChange={handleElementChange} onChangeCommitted={handleElementChange} />;

// this is structurally equal to `React.SyntheticEvent`
// It works but we don't recommend it since it has some non-structural implications: changeEvent.target === changeEvent.currentTarget
function handleChange(event: React.ChangeEvent<{}>) {}
<Slider onChange={handleChange} />;
}
8 changes: 4 additions & 4 deletions packages/material-ui-lab/src/TreeView/TreeView.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,14 @@ export interface TreeViewPropsBase extends StandardProps<React.HTMLAttributes<HT
* @param {object} event The event source of the callback
* @param {string} value of the focused node.
*/
onNodeFocus?: (event: React.ChangeEvent<{}>, nodeId: string) => void;
onNodeFocus?: (event: React.SyntheticEvent, nodeId: string) => void;
/**
* Callback fired when tree items are expanded/collapsed.
*
* @param {object} event The event source of the callback.
* @param {array} nodeIds The ids of the expanded nodes.
*/
onNodeToggle?: (event: React.ChangeEvent<{}>, nodeIds: string[]) => void;
onNodeToggle?: (event: React.SyntheticEvent, nodeIds: string[]) => void;
}

export interface MultiSelectTreeViewProps extends TreeViewPropsBase {
Expand All @@ -95,7 +95,7 @@ export interface MultiSelectTreeViewProps extends TreeViewPropsBase {
* @param {(array|string)} value of the selected nodes. When `multiSelect` is true
* this is an array of strings; when false (default) a string.
*/
onNodeSelect?: (event: React.ChangeEvent<{}>, nodeIds: string[]) => void;
onNodeSelect?: (event: React.SyntheticEvent, nodeIds: string[]) => void;
}

export interface SingleSelectTreeViewProps extends TreeViewPropsBase {
Expand All @@ -122,7 +122,7 @@ export interface SingleSelectTreeViewProps extends TreeViewPropsBase {
* @param {(array|string)} value of the selected nodes. When `multiSelect` is true
* this is an array of strings; when false (default) a string.
*/
onNodeSelect?: (event: React.ChangeEvent<{}>, nodeIds: string) => void;
onNodeSelect?: (event: React.SyntheticEvent, nodeIds: string) => void;
}

export type TreeViewProps = SingleSelectTreeViewProps | MultiSelectTreeViewProps;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export interface UseAutocompleteProps<
* @param {object} event The event source of the callback.
* @param {string} reason Can be: `"toggleInput"`, `"escape"`, `"select-option"`, `"remove-option"`, `"blur"`.
*/
onClose?: (event: React.ChangeEvent<{}>, reason: AutocompleteCloseReason) => void;
onClose?: (event: React.SyntheticEvent, reason: AutocompleteCloseReason) => void;
/**
* Callback fired when the input value changes.
*
Expand All @@ -192,7 +192,7 @@ export interface UseAutocompleteProps<
* @param {string} reason Can be: `"input"` (user input), `"reset"` (programmatic change), `"clear"`.
*/
onInputChange?: (
event: React.ChangeEvent<{}>,
event: React.SyntheticEvent,
value: string,
reason: AutocompleteInputChangeReason
) => void;
Expand All @@ -202,7 +202,7 @@ export interface UseAutocompleteProps<
*
* @param {object} event The event source of the callback.
*/
onOpen?: (event: React.ChangeEvent<{}>) => void;
onOpen?: (event: React.SyntheticEvent) => void;
/**
* Callback fired when the highlight option changes.
*
Expand All @@ -211,7 +211,7 @@ export interface UseAutocompleteProps<
* @param {string} reason Can be: `"keyboard"`, `"auto"`, `"mouse"`.
*/
onHighlightChange?: (
event: React.ChangeEvent<{}>,
event: React.SyntheticEvent,
option: T | null,
reason: AutocompleteHighlightChangeReason
) => void;
Expand Down Expand Up @@ -259,7 +259,7 @@ export interface UseAutocompleteProps<
* @param {string} reason One of "create-option", "select-option", "remove-option", "blur" or "clear".
*/
onChange?: (
event: React.ChangeEvent<{}>,
event: React.SyntheticEvent,
value: Value<T, Multiple, DisableClearable, FreeSolo>,
reason: AutocompleteChangeReason,
details?: AutocompleteChangeDetails<T>
Expand Down
7 changes: 0 additions & 7 deletions packages/material-ui/src/Accordion/Accordion.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,4 @@ function testOnChange() {
>
<div />
</Accordion>;

// this is structurally equal to `React.SyntheticEvent`
// It works but we don't recommend it since it has some non-structural implications: changeEvent.target === changeEvent.currentTarget
function handleChange(event: React.ChangeEvent<{}>) {}
<Accordion onChange={handleChange}>
<div />
</Accordion>;
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,4 @@ function testOnChange() {
// @ts-expect-error internally it's whatever even lead to a change in value
onChange={handleElementChange}
/>;

// this is structurally equal to `React.SyntheticEvent`
// It works but we don't recommend it since it has some non-structural implications: changeEvent.target === changeEvent.currentTarget
function handleChange(event: React.ChangeEvent<{}>) {}
<BottomNavigation onChange={handleChange} />;
}
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export interface FormControlLabelProps
* @param {object} event The event source of the callback.
* You can pull out the new checked state by accessing `event.target.checked` (boolean).
*/
onChange?: (event: React.ChangeEvent<{}>, checked: boolean) => void;
onChange?: (event: React.SyntheticEvent, checked: boolean) => void;
/**
* The value of the component.
*/
Expand Down
4 changes: 2 additions & 2 deletions packages/material-ui/src/Select/Select.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,14 @@ export interface SelectProps
*
* @param {object} event The event source of the callback.
*/
onClose?: (event: React.ChangeEvent<{}>) => void;
onClose?: (event: React.SyntheticEvent) => void;
/**
* Callback fired when the component requests to be opened.
* Use in controlled mode (see open).
*
* @param {object} event The event source of the callback.
*/
onOpen?: (event: React.ChangeEvent<{}>) => void;
onOpen?: (event: React.SyntheticEvent) => void;
/**
* Control `select` open state.
* You can only use it when the `native` prop is `false` (default).
Expand Down
4 changes: 2 additions & 2 deletions packages/material-ui/src/Select/SelectInput.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ export interface SelectInputProps {
event: React.ChangeEvent<{ name?: string; value: unknown }>,
child: React.ReactNode
) => void;
onClose?: (event: React.ChangeEvent<{}>) => void;
onClose?: (event: React.SyntheticEvent) => void;
onFocus?: React.FocusEventHandler<any>;
onOpen?: (event: React.ChangeEvent<{}>) => void;
onOpen?: (event: React.SyntheticEvent) => void;
open?: boolean;
readOnly?: boolean;
renderValue?: (value: SelectInputProps['value']) => React.ReactNode;
Expand Down
5 changes: 0 additions & 5 deletions packages/material-ui/src/Slider/Slider.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,4 @@ function testOnChange() {
function handleElementChange(event: React.ChangeEvent) {}
// @ts-expect-error internally it's whatever even lead to a change in value
<Slider onChange={handleElementChange} onChangeCommitted={handleElementChange} />;

// this is structurally equal to `React.SyntheticEvent`
// It works but we don't recommend it since it has some non-structural implications: changeEvent.target === changeEvent.currentTarget
function handleChange(event: React.ChangeEvent<{}>) {}
<Slider onChange={handleChange} />;
}
5 changes: 0 additions & 5 deletions packages/material-ui/src/Tabs/Tabs.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,4 @@ function testOnChange() {
// @ts-expect-error internally it's either FocusEvent or ClickEvent
onChange={handleElementChange}
/>;

// this is structurally equal to `React.SyntheticEvent`
// It works but we don't recommend it since it has some non-structural implications: changeEvent.target === changeEvent.currentTarget
function handleChange(event: React.ChangeEvent<{}>) {}
<Tabs onChange={handleChange} />;
}