Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Replace ChangeEvent<{}> with SyntheticEvent #22716

Merged
merged 1 commit into from
Sep 24, 2020
Merged

[core] Replace ChangeEvent<{}> with SyntheticEvent #22716

merged 1 commit into from
Sep 24, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 24, 2020

Follow-up on #21552.

-<Component onX={(event: React.ChangeEvent<{}>) => {}} />
+<Component onX={(event: React.SyntheticEvent) => {}} />

for:

  • AutoComplete (onChange, onHighlightChange, onOpen)
  • FormControlLabel (onChange)
  • Rating (onChange)
  • Select (onClose, onOpen)
  • TreeView (onNodeFocus, onNodeToggle)

@eps1lon eps1lon added component: select This is the name of the generic UI component, not the React module! typescript component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! component: rating This is the name of the generic UI component, not the React module! component: autocomplete This is the name of the generic UI component, not the React module! labels Sep 24, 2020
@mui-pr-bot
Copy link

No bundle size changes comparing 4767e78...223d3e4

Generated by 🚫 dangerJS against 223d3e4

@github-actions github-actions bot mentioned this pull request Sep 24, 2020
Closed
@eps1lon eps1lon marked this pull request as ready for review September 24, 2020 12:01
@eps1lon eps1lon merged commit 4f21dfc into mui:next Sep 24, 2020
@eps1lon eps1lon deleted the fix/change-event-any branch September 24, 2020 14:01
@ivan-freedomfi ivan-freedomfi mentioned this pull request May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module! component: rating This is the name of the generic UI component, not the React module! component: select This is the name of the generic UI component, not the React module! component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @mui-pr-bot @oliviertassinari