-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vsdownload: Filter packages based on their arch information #149
Conversation
efb47b3
to
135b12f
Compare
The example in the description is actually not correct.
So this package is not for pure ARM64. So anyway So I am going the implement the filter matching host arch exactly. |
135b12f
to
0e42e7c
Compare
|
0e42e7c
to
e30c5ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good overall, except for the cosmetic issue
e30c5ec
to
11f3a77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Depends on #148.
Match host arch with
chip
,machineArch
andproductArch
.PR #148
PR #149 matching host arch exactly
EDIT: We go matching host arch exactly.
PR #149Selected 463 packages, for a total download size of 2.6 GB, install size of 8.3 GBCurrent implementation apply the knownledge thatOtherwise some packages will be incomplete. E.g. package
Microsoft.VisualStudio.Debugger.Remote
on ARM64:But I think matching host arch exactly is also acceptable, and user need to specify
Microsoft.VisualStudio.Debugger.Remote.ARM64
instead ofMicrosoft.VisualStudio.Debugger.Remote
.