Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsdownload: Add an option to skip packages that do not match host arch #148

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

huangqinjin
Copy link
Contributor

@huangqinjin huangqinjin commented Oct 5, 2024

Depends on #140.

Some packages have their host arch in their ids, e.g.

"Microsoft.VisualCpp.Tools.HostARM64.TargetX64"
"Microsoft.VisualCpp.Tools.HostARM64.TargetX86"
"Microsoft.VisualCpp.Tools.HostX64.TargetX64"
"Microsoft.VisualCpp.Tools.HostX64.TargetX86"

I think it is pretty safe to skip packages if their ids do not match host arch.

PR #140

Selected 544 packages, for a total download size of 2.9 GB, install size of 8.9 GB

PR #148

Selected 475 packages, for a total download size of 2.7 GB, install size of 8.5 GB

@mstorsjo
Copy link
Owner

mstorsjo commented Oct 5, 2024

Thanks, this looks like a nice addition! However for some cases I guess it would be nice to be able to unpack all of them; would it be possible to add an option that lets the user get all of them?

@huangqinjin
Copy link
Contributor Author

A option is reasonable to me. But the main reason for me is that such filters based on host arch will going to be wrong in future, e.g. I want to filter packages based on their chip, machineArch and productArch.

Is --only-host a good name? What is the default value we want?

@huangqinjin huangqinjin changed the title vsdownload: Skip packages if their ids do not match host arch vsdownload: Add an option to skip packages that do not match host arch Oct 6, 2024
@mstorsjo
Copy link
Owner

mstorsjo commented Oct 7, 2024

A option is reasonable to me. But the main reason for me is that such filters based on host arch will going to be wrong in future, e.g. I want to filter packages based on their chip, machineArch and productArch.

Is --only-host a good name? What is the default value we want?

This looks like a reasonable name, and yes, we want the default to be to only unpack things for the host arch - as normal users won't need to think about this option. Thanks!

Copy link
Owner

@mstorsjo mstorsjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mstorsjo mstorsjo merged commit f7e6662 into mstorsjo:master Oct 9, 2024
4 checks passed
@huangqinjin huangqinjin deleted the host-arch-only branch October 9, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants